Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show a handy message when calling ./socrata/ if no instances have been registered #5

Closed
jgravois opened this issue Nov 4, 2014 · 3 comments · Fixed by #6
Closed

Comments

@jgravois
Copy link

jgravois commented Nov 4, 2014

i got myself kind of confused today before realizing a SQL error was to be expected when calling koop/socrata prior to registering an actual datastore.

it would be worthwhile to trap this error and display an informative message. please assign this enhancement to me. i think i can handle implementing the code change here

@chelm
Copy link
Contributor

chelm commented Nov 4, 2014

@jgravois Yes I actually do this in the agol provider and just didn't get around to getting it into Socrata.

I think it'd be best to actually trap the error in the find method on the model like it's been done here: https://github.com/Esri/koop-agol/blob/master/models/agol.js#L38 - does that make sense?

The find method in the Socrata model is here:
https://github.com/chelm/koop-socrata/blob/master/models/Socrata.js#L27

@jgravois jgravois mentioned this issue Nov 4, 2014
@jgravois
Copy link
Author

jgravois commented Nov 4, 2014

thanks for the recommendation. PR submitted. closing this issue.

@jgravois jgravois closed this as completed Nov 4, 2014
@chelm
Copy link
Contributor

chelm commented Nov 4, 2014

COOL!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants