Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kart breaks when geojson output is used in conflicts command and conflict only affects schemas #515

Closed
volaya opened this issue Nov 30, 2021 · 0 comments · Fixed by #584
Closed
Labels
good first issue Good for newcomers

Comments

@volaya
Copy link

volaya commented Nov 30, 2021

To reproduce:

  • Modify a dataset changing its schema
  • Make a different schema change in a different branch
  • Merge branches.

The merge operation will result in conflicts.

Run kart conflicts -ogeojson

The following error is raised:

Traceback (most recent call last):
  File "kart_cli.py", line 4, in <module>
  File "kart\cli.py", line 340, in entrypoint
  File "lib\site-packages\click\core.py", line 829, in __call__
  File "lib\site-packages\click\core.py", line 782, in main
  File "kart\cli.py", line 163, in invoke
  File "lib\site-packages\click\core.py", line 1259, in invoke
  File "lib\site-packages\click\core.py", line 1066, in invoke
  File "lib\site-packages\click\core.py", line 610, in invoke
  File "lib\site-packages\click\decorators.py", line 21, in new_func
  File "kart\conflicts.py", line 294, in conflicts
  File "kart\conflicts.py", line 86, in list_conflicts
  File "kart\conflicts.py", line 214, in conflicts_json_as_geojson
TypeError: list indices must be integers or slices, not str
[18628] Failed to execute script kart_cli

It doesn'tmake sense to use the geojson output format in this case, but I guess that the command should fail more gracefully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants