diff -o json-lines: Add feature count estimate
#543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigds
commented
Jan 16, 2022
UberMouse
reviewed
Jan 16, 2022
|
needs adding to the changelog but I see 0.11.0 RCs have been minted so perhaps we can just hold off merging this until 0.11.0 is released and then add it in after that |
With new `--add-feature-count-estimate=<accuracy>` option, adds a line to the output stating the number of features expected to be in the diff. This should be useful for showing a progress bar when the diff is large. For small diffs it may never appear, as the estimate can easily take longer to calculate than the whole diff anyway.
Remove 'daemon' thread, as it can apparently be dangerous
craigds
force-pushed
the
jsonl-diff-estimate
branch
from
d474f72
to
c9ba3cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With new
--add-feature-count-estimate=<accuracy>option, adds a lineto the output stating the number of features expected to be in
the diff. This should be useful for showing a progress bar when the diff is
large.
For small diffs it may never appear, as the estimate can easily take
longer to calculate than the whole diff anyway.
Related links:
Checklist: