You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Running the tests with warnings enabled (pytest -ra) displays the following near the end of the test run:
==================================================== warnings summary =====================================================
tests/test_checkout.py::test_reset
tests/test_checkout.py::test_reset
/Users/cdestigter/checkout/kart/kart/log.py:80: RemovalInKart012Warning: '--oneline' is unknown to Kart and will be passed directly to git. This will be removed in Kart 0.12! Please comment on https://github.com/koordinates/kart/issues/508 if you need to use this option.
RemovalInKart012Warning,
tests/test_checkout.py::test_reset
tests/test_checkout.py::test_reset
/Users/cdestigter/checkout/kart/kart/log.py:80: RemovalInKart012Warning: '--decorate=short' is unknown to Kart and will be passed directly to git. This will be removed in Kart 0.12! Please comment on https://github.com/koordinates/kart/issues/508 if you need to use this option.
RemovalInKart012Warning,
tests/test_init.py::test_init_import_custom_message
/Users/cdestigter/checkout/kart/kart/log.py:80: RemovalInKart012Warning: '-1' is unknown to Kart and will be passed directly to git. This will be removed in Kart 0.12! Please comment on https://github.com/koordinates/kart/issues/508 if you need to use this option.
RemovalInKart012Warning,
tests/test_log.py::test_log_arg_handling[text]
/Users/cdestigter/checkout/kart/kart/log.py:80: RemovalInKart012Warning: '-p' is unknown to Kart and will be passed directly to git. This will be removed in Kart 0.12! Please comment on https://github.com/koordinates/kart/issues/508 if you need to use this option.
RemovalInKart012Warning,
However, some existing tests are running kart log with various options that are not explicitly defined, so they are causing these warnings in the tests.
Fix plan
To solve this, we should:
Switch from --oneline to the explicitly-supported -o text:oneline
Add explicit support for --no-decorate, --decorate[=short|full|auto|no], again only when using text output
Switch from -1 to -n 1
Avoid using -p, find another way to do whatever that test is trying to do.
The text was updated successfully, but these errors were encountered:
Background
Running the tests with warnings enabled (
pytest -ra
) displays the following near the end of the test run:As per #508 ,
kart log
currently passes unknown options on to agit log
subprocess. In 0.12 we want to change that, and instead explicitly define all the options we need (here are somegit log
options we've already explicitly supported)However, some existing tests are running
kart log
with various options that are not explicitly defined, so they are causing these warnings in the tests.Fix plan
To solve this, we should:
--oneline
to the explicitly-supported-o text:oneline
--no-decorate, --decorate[=short|full|auto|no]
, again only when using text output-1
to-n 1
-p
, find another way to do whatever that test is trying to do.The text was updated successfully, but these errors were encountered: