Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This code adds complexity and doesn't help since the repo layout
optimisations were introduced in Datasets V3, although
it probably does speed up datasets with string primary keys.
With sequential integer primary keys, it just results in idle processes
since features from a sequence are consistently fed into the same
process, resulting in no efficiency gain.
Since this code is quite complex, it doesn't make sense to keep it
On my laptop, I got these results:
--num-processes=10
:--num-processes=1
:The idle processes can be seen in Activity Monitor:
Related links:
.
Checklist: