Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import from postgres databases #90

Merged
merged 14 commits into from
Jun 16, 2020
Merged

Import from postgres databases #90

merged 14 commits into from
Jun 16, 2020

Conversation

craigds
Copy link
Member

@craigds craigds commented May 26, 2020 •
edited
Loading

This adds support for importing from Postgres databases using a connection string:

$ sno init --import 'postgresql://docker:docker@localhost:5432/gis' --table TABLE

To do:

  • Enable running the postgres import test in CI
  • vendor-add-pq needs to be merged before this
  • postgres test needs to run/pass in linux in CI

@craigds craigds requested review from rcoup and olsen232 May 26, 2020 03:59
@craigds craigds force-pushed the postgres-import branch 4 times, most recently from a5cf616 to 81ad767 Compare May 27, 2020 07:20
rcoup
rcoup reviewed May 27, 2020
View reviewed changes
sno/init.py Outdated Show resolved Hide resolved
sno/init.py Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@craigds craigds force-pushed the postgres-import branch 3 times, most recently from bef2de1 to 63bc890 Compare May 27, 2020 20:58
olsen232
olsen232 reviewed May 27, 2020
View reviewed changes
sno/init.py Show resolved Hide resolved
olsen232
olsen232 reviewed May 27, 2020
View reviewed changes
tests/test_structure.py Outdated Show resolved Hide resolved
olsen232
olsen232 reviewed May 27, 2020
View reviewed changes
Copy link
Collaborator

@olsen232 olsen232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't really have the knowledge to comment on postgres stuff but I had a look

craigds added a commit that referenced this pull request May 27, 2020
@craigds
import: Tweaks from #90 review
13d0877
craigds added a commit that referenced this pull request Jun 9, 2020
@craigds
import: Tweaks from #90 review
0a14ae0
@rcoup rcoup changed the base branch from vendor-add-pq to master June 11, 2020 16:59
@rcoup
Copy link
Member

rcoup commented Jun 11, 2020

@craigds I changed the base on this to master now vendor-add-pq was merged

craigds added a commit that referenced this pull request Jun 11, 2020
@craigds
import: Tweaks from #90 review
281d719
craigds added a commit that referenced this pull request Jun 12, 2020
@craigds
import: Tweaks from #90 review
2315121
@craigds craigds force-pushed the postgres-import branch 3 times, most recently from 0a4eb83 to 396266f Compare June 12, 2020 03:56
craigds added a commit that referenced this pull request Jun 13, 2020
@craigds
import: Tweaks from #90 review
8a0a100
@craigds
Import from postgres databases
332d9b0
@craigds
Enable postgres import test in CI
6bd52ad 
env is duplicated, but github actions doesn't support anchors in their
YAML so I don't know any other way to do this atm
@craigds
import: explicitly don't handle multi-column PK
b2ce97b
@craigds
import: Handle domain sockets for postgres conns
e42ea19 
and test it
@craigds craigds marked this pull request as ready for review June 14, 2020 23:05
@craigds craigds requested a review from rcoup June 14, 2020 23:05
@craigds craigds merged commit 209908d into master Jun 16, 2020
@craigds craigds deleted the postgres-import branch June 16, 2020 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olsen232 olsen232 olsen232 left review comments

@rcoup rcoup Awaiting requested review from rcoup

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@craigds @rcoup @olsen232