New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing all features of a layer causes error when merging #506

Closed

volaya opened this issue Nov 17, 2021 · 1 comment

volaya commented Nov 17, 2021

To reproduce:

Create a repo and add a layer with some features
Create a new branch
In the new branch, remove all features from the layer and commit
switch back to main branch and try to merge the new branch onto it.

This workflow is already implemented in a test in the Kart QGIS plugin test suite, and the error trace can be found here:

https://github.com/volaya/kart-qgis-plugin/runs/4237417438?check_suite_focus=true#step:3:548

The test that causes this error can be found here:

https://github.com/volaya/kart-qgis-plugin/blob/main/kart/tests/test_kartapi.py#L233

olsen232 added a commit that referenced this issue


          Fix for #506 - error when all features deleted

882ced1

olsen232 added a commit that referenced this issue


          Fix for #506 - error when all features deleted

7f90181

Collaborator

olsen232 commented Nov 26, 2021

Fixed at 7f90181

olsen232 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment