Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: report cpu info to noderesoucetopology #312

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

ZYecho
Copy link
Contributor

@ZYecho ZYecho commented Jun 24, 2022

Signed-off-by: Yue Zhang huaihuan.zy@alibaba-inc.com

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fix #264

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

pkg/koordlet/statesinformer/config.go Outdated Show resolved Hide resolved
pkg/koordlet/statesinformer/config.go Outdated Show resolved Hide resolved
@ZYecho ZYecho force-pushed the huaihuan branch 2 times, most recently from cd63426 to ae29d79 Compare June 27, 2022 08:04
@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #312 (04c88cd) into main (8a5fee9) will decrease coverage by 0.01%.
The diff coverage is 62.50%.

@@            Coverage Diff             @@
##             main     #312      +/-   ##
==========================================
- Coverage   63.55%   63.53%   -0.02%     
==========================================
  Files         106      107       +1     
  Lines        9754     9897     +143     
==========================================
+ Hits         6199     6288      +89     
- Misses       3062     3101      +39     
- Partials      493      508      +15     
Flag Coverage Δ
unittests 63.53% <62.50%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/koordlet/statesinformer/states_node.go 25.80% <0.00%> (-1.78%) ⬇️
pkg/koordlet/statesinformer/states_informer.go 39.56% <60.00%> (+0.30%) ⬆️
...dlet/statesinformer/states_noderesourcetopology.go 62.96% <62.96%> (ø)
pkg/koordlet/statesinformer/config.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a5fee9...04c88cd. Read the comment docs.

apis/extension/node.go Outdated Show resolved Hide resolved
pkg/koordlet/statesinformer/config.go Outdated Show resolved Hide resolved
@ZYecho ZYecho force-pushed the huaihuan branch 3 times, most recently from 7a4a247 to 2ccf7f3 Compare June 28, 2022 06:04
@jasonliu747 jasonliu747 requested a review from eahydra June 28, 2022 06:49
Signed-off-by: Yue Zhang <huaihuan.zy@alibaba-inc.com>
@zwzhang0107
Copy link
Contributor

/lgtm

@hormes
Copy link
Member

hormes commented Jun 28, 2022

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hormes hormes merged commit 86097cc into koordinator-sh:main Jun 28, 2022
@ZYecho ZYecho deleted the huaihuan branch June 28, 2022 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[proposal] report cpu-topology and cpuset allocs for cpu fine-grained orchestration
6 participants