Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cli): break down observability.startMetrics() #3196

Merged
merged 5 commits into from
Aug 6, 2023

Simplify maybeStartMetricsPusher

9d2a6db
Select commit
Failed to load commit list.
Merged

refactor(cli): break down observability.startMetrics() #3196

Simplify maybeStartMetricsPusher
9d2a6db
Select commit
Failed to load commit list.
Codecov / codecov/project succeeded Aug 6, 2023 in 0s

75.41% (target 62.00%)

View this Pull Request on Codecov

75.41% (target 62.00%)

Details

Codecov Report

Patch coverage: 77.04% and project coverage change: -0.02% ⚠️

Comparison is base (0d2a7c8) 75.43% compared to head (9d2a6db) 75.41%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3196      +/-   ##
==========================================
- Coverage   75.43%   75.41%   -0.02%     
==========================================
  Files         459      459              
  Lines       36456    36465       +9     
==========================================
  Hits        27501    27501              
- Misses       7042     7048       +6     
- Partials     1913     1916       +3     
Files Changed Coverage Δ
cli/observability_flags.go 81.61% <77.04%> (+4.45%) ⬆️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.