Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(cli): break down observability.startMetrics() #3196

Merged
merged 5 commits into from
Aug 6, 2023

Simplify maybeStartMetricsPusher

9d2a6db
Select commit
Loading
Failed to load commit list.
Merged

refactor(cli): break down observability.startMetrics() #3196

Simplify maybeStartMetricsPusher
9d2a6db
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Aug 6, 2023 in 1s

77.04% of diff hit (target 75.43%)

View this Pull Request on Codecov

77.04% of diff hit (target 75.43%)

Annotations

Check warning on line 98 in cli/observability_flags.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

cli/observability_flags.go#L97-L98 

Added lines #L97 - L98 were not covered by tests

Check warning on line 106 in cli/observability_flags.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

cli/observability_flags.go#L100-L106 

Added lines #L100 - L106 were not covered by tests

Check warning on line 109 in cli/observability_flags.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

cli/observability_flags.go#L109 

Added line #L109 was not covered by tests

Check warning on line 111 in cli/observability_flags.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

cli/observability_flags.go#L111 

Added line #L111 was not covered by tests

Check warning on line 165 in cli/observability_flags.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

cli/observability_flags.go#L164-L165 

Added lines #L164 - L165 were not covered by tests
View more details on Codecov