Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-generated FFI bindings #1

Open
emoon opened this issue Jun 18, 2020 · 3 comments
Open

Pre-generated FFI bindings #1

emoon opened this issue Jun 18, 2020 · 3 comments

Comments

@emoon
Copy link
Contributor

emoon commented Jun 18, 2020

Hi,

First of all thanks for a great crate :)

I wonder if it would be possible to change this crate to include a pre-generated file of the Rust bindings made in this code https://github.com/koraa/xxhrs/blob/master/build.rs#L32-L42 ?

The reason I'm asking for this is that the dependency on bindgen adds quite a bit of extra compile time as it depends on clang which is quite heavy dependency wise.

@koraa
Copy link
Owner

koraa commented Jun 18, 2020

Sure! Would you mind creating a pull request?

@emoon
Copy link
Contributor Author

emoon commented Jun 18, 2020

Sure! I can do that :)

@koraa
Copy link
Owner

koraa commented Jun 18, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants