Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): sentry throwing error on no user #652

Merged
merged 3 commits into from
Feb 1, 2024
Merged

Conversation

timonmasberg
Copy link
Member

@timonmasberg timonmasberg commented Feb 1, 2024

Description

For now, we always assumed, that after the auth interceptor we always have a user set. In the sentry interceptor, this lead to an error when calling the /health-check. Implemented a check for user being present or not.

Checklist:

  • The title of this PR and the commit history is conform with
    the Conventional Commits specification.
  • I have performed a self-review of my own code.
  • My changes generate no new warnings, SonarCloud reports no Vulnerabilities, Bugs or Code Smells.
  • I have added tests (unit and E2E if user-facing) that prove my fix is effective or that my feature works,
    Coverage > 80% and not less than the current coverage of the main branch.
  • The PR branch is up-to-date with the base branch. In case you merged main into your feature branch, make sure you have run the latest NX migrations (nx migrate --run-migrations).

@timonmasberg timonmasberg enabled auto-merge (squash) February 1, 2024 10:26
Copy link

sonarcloud bot commented Feb 1, 2024

@timonmasberg timonmasberg merged commit 8683454 into main Feb 1, 2024
10 checks passed
@timonmasberg timonmasberg deleted the fix/sentry-no-user branch February 1, 2024 10:34
@timonmasberg
Copy link
Member Author

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants