reduce disk usage of thirdparty build directories #1578
Conversation
- shallower clones - sparse checkouts for the initial repos - support not fetching/setting up any submodules
benoit-pierre
force-pushed
the
trimming_the_fat
branch
from
33c75d6
to
475e6b0
Compare
| @@ -69,79 +60,76 @@ if(should_clone) | |||
| if(error_code) | |||
| message(FATAL_ERROR \"Failed to clone repository: '${git_repository}'\") | |||
| endif() | |||
| execute_process( | |||
| COMMAND \"${git_EXECUTABLE}\" -C \"${clone_checkout}\" sparse-checkout init | |||
There was a problem hiding this comment.
This isn't supported yet. But thanks for providing the update.
There was a problem hiding this comment.
Note: the code should be robust to sparse-checkout not being supported (exit codes are ignored for that reason).
|
It's a bit unclear to me how you managed to make CircleCI not run. Do you have any idea? |
|
Eh well, I think it's fine with a quick try, though it's lacking the peace of mind of having a multitude of configurations checked. Now running on master: https://github.com/koreader/koreader-base/runs/11450672853 |
No idea, but from past experience Circle CI can be a bit funky. |
|
Have you considered converting those jobs to use Github Actions? |
|
No looking good on master... |
|
I'm looking into it, seems like mupdf is missing some variables (e.g. |
GitHub Actions is unfortunately not fit for purpose. See #1442 (comment) and #1464. |
Stats after building 3 versions (emulator debug & release versions, kindlepw2 release version):
thirdparty/*/build/git_checkoutthirdparty/*/build/x86_64-pc-linux-gnuthirdparty/*/build/x86_64-pc-linux-gnu-debugthirdparty/*/build/arm-kindlepw2-linux-gnueabithirdparty/*/buildStill high, but much better.
This change is