Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDL: miscellaneous fixes #1585

Merged
merged 2 commits into from
Feb 19, 2023
Merged

SDL: miscellaneous fixes #1585

merged 2 commits into from
Feb 19, 2023

Conversation

benoit-pierre
Copy link
Contributor

@benoit-pierre benoit-pierre commented Feb 19, 2023 •
edited by Frenzie
Loading

  • fix a heap buffer overflow
  • fix some (minor) memory leaks

This change is Reviewable

@benoit-pierre
SDL: fix heap buffer overflow
2ae6ccc 
Reported by both GCC's ASAN and Valgrind.
Frenzie
Frenzie reviewed Feb 19, 2023
View reviewed changes
ffi/SDL2_0_h.lua Outdated Show resolved Hide resolved
@Frenzie Frenzie merged commit d3acf19 into koreader:master Feb 19, 2023
NiLuJe added a commit to NiLuJe/koreader that referenced this pull request Feb 20, 2023
@NiLuJe
Bump base
e824b12 
koreader/koreader-base#1578
koreader/koreader-base#1585
koreader/koreader-base#1586
koreader/koreader-base#1584
@benoit-pierre benoit-pierre deleted the pr/miscellaneous_sdl_fixes branch February 21, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Frenzie Frenzie Frenzie left review comments

@NiLuJe NiLuJe NiLuJe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benoit-pierre @NiLuJe @Frenzie