Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

luajit: ensure ccache is used #1710

Merged
merged 1 commit into from
Dec 3, 2023
Merged

luajit: ensure ccache is used #1710

merged 1 commit into from
Dec 3, 2023

Conversation

benoit-pierre
Copy link
Contributor

@benoit-pierre benoit-pierre commented Dec 2, 2023 •
edited by Frenzie
Loading

This change is Reviewable

@Frenzie Frenzie requested a review from NiLuJe December 3, 2023 09:00
NiLuJe
NiLuJe approved these changes Dec 3, 2023
View reviewed changes
Copy link
Member

@NiLuJe NiLuJe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not familiar with ccache (at all) and it's not like we can see anything without verbose builds, but it looks sound ;).

@Frenzie Frenzie merged commit d83fc50 into koreader:master Dec 3, 2023
2 checks passed
@benoit-pierre benoit-pierre deleted the pr/fix_luajit_ccache branch December 4, 2023 15:34
NiLuJe added a commit to NiLuJe/koreader that referenced this pull request Dec 7, 2023
@NiLuJe
Bump base
60fafcf 
koreader/koreader-base#1708
koreader/koreader-base#1706
koreader/koreader-base#1707
koreader/koreader-base#1711
koreader/koreader-base#1710
koreader/koreader-base#1709
koreader/koreader-base#1712
NiLuJe added a commit to koreader/koreader that referenced this pull request Dec 8, 2023
@NiLuJe
Bump base
9ebe771 
koreader/koreader-base#1708
koreader/koreader-base#1706
koreader/koreader-base#1707
koreader/koreader-base#1711
koreader/koreader-base#1710
koreader/koreader-base#1709
koreader/koreader-base#1712
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiLuJe NiLuJe NiLuJe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@benoit-pierre @NiLuJe @Frenzie