PocketBook: Try to handle MTSYNC properly #1712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on a semi-educated guess given what https://github.com/imustafin/pbdoom is doing... It *sortof* makes sense, given the new SDK 6 stuff and the behavior I noticed, so, eeeeh. I fully expect this to horribly break on devices without GetTouchInfoI support, though, regardless of our compat shim ;D. Followup to koreader#1662
contacts before the lift Oops. That definitely explains why GD was picking up stale contacts all over the place ;p.
|
Ping @LukasKnuth (koreader/koreader#11111), @mafes1 (koreader/koreader#10950), @zmixnyc (koreader/koreader#11196) for more testers ;). |
NiLuJe
commented
Dec 7, 2023
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @NiLuJe)
NiLuJe
added a commit
to NiLuJe/koreader
that referenced
this pull request
Dec 7, 2023
NiLuJe
added a commit
to koreader/koreader
that referenced
this pull request
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on a semi-educated guess given what https://github.com/imustafin/pbdoom is doing...
It sortof makes sense, given the new SDK 6 stuff and the behavior I noticed, so, eeeeh.
I fully expect this to horribly break on devices without GetTouchInfoI support, though, regardless of our compat shim ;D.
Followup to #1662
This change is