-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mupdf: pre update cleanups #1791
mupdf: pre update cleanups #1791
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preferably for after #1750?
Yes (will conflict in |
- fix `fz_recognize_image_format` prototype: need at least 12 bytes to be able to probe for a possible WebP image - fix ICC support flag check - flag WebP support so it can be disabled
- flag the feature so it can be disabled - tweak patch to make it easier to update (reduce conflicts)
Fix warnings.
1f07141
to
2d26de5
Compare
Ready to merge or would you rather wait until there's a nightly with all the other changes out first? |
Up to you, I have the MuPDF update and the leptonica+tesseract+libk2pfopt updates ready. |
I mean, this can be merged without waiting, but wait for a nightly or 2 before the proper updates? |
I've manually triggered a pipeline run speed up the process a little. If everything seems fine I'll merge some more things here but indeed let's wait with the actual update a couple of days. |
Welp, it did not take long: https://gitlab.com/koreader/nightly-builds/-/jobs/6973852572. |
OK, fix incoming (need to remove |
Nobody expects the |
There's one minor fix (correct
fz_recognize_image_format
's prototype), but mostly tweak some patches to make updating easier (e.g. reduce conflicts), and trim FFI cdecls to keep only the declarations we need.This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)