fix building for kindle-legacy target
#1798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hold on, did that say: I don't think that sounds right (despite the name "legacy"). It should still be GCC 11. Edit: to onlookers, see https://gitlab.com/koreader/nightly-builds/-/jobs/6973852572 and #1791 (comment) for some preceding context. |
|
I think this is right: those are the 2 toolchains really lagging behind, Cf. https://github.com/koreader/koxtoolchain/blob/master/gen-tc.sh#L133. ▹ ~/dev/x-tools/arm-pocketbook-linux-gnueabi/bin/arm-pocketbook-linux-gnueabi-gcc --version
arm-pocketbook-linux-gnueabi-gcc (crosstool-NG 1.23.0.90-9954e26 - NiLuJe) 7.5.0
Copyright (C) 2017 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. |
|
Yes, I had just spotted the same comment. I probably knew all this very well around the time of the PB troubles. The troubles being that it was stuck on something like 4.6 or 4.7; 7.5 is delightfully new in comparison. ;-) |
Frenzie
pushed a commit
to koreader/koreader
that referenced
this pull request
May 31, 2024
Preliminary bump (koreader/koreader-base#1800 will be included in #11930): - koreader/koreader-base#1790 - koreader/koreader-base#1795 - koreader/koreader-base#1796 - koreader/koreader-base#1797 - koreader/koreader-base#1798 - koreader/koreader-base#1799 - koreader/koreader-base#1801 - koreader/koreader-base#1802 - koreader/koreader-base#1803 - koreader/koreader-base#1804
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is