Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump crengine: minor fixes (ruby, a crash, non-linear flows) #1792

Merged
merged 1 commit into from
May 20, 2024

Conversation

poire-z
Copy link
Contributor

@poire-z poire-z commented May 20, 2024

Includes koreader/crengine#565 :

  • html5.css: really ensure ruby centering
  • getRenderedWidths(): fix possible crash with 0-width images
  • Page splitting: ignore empty non-linear flows
  • LvDocView header: allow overriding "page/total %"

cre.cpp: add setPageInfoOverride() to allow tweaking top status bar display of page number/count/%.


This change is Reviewable

Includes:
- html5.css: really ensure ruby centering
- getRenderedWidths(): fix possible crash with 0-width images
- Page splitting: ignore empty non-linear flows
- LvDocView header: allow overriding "page/total %"

cre.cpp: add setPageInfoOverride() to allow tweaking
top status bar display of page number/count/%.
Copy link
Member

@Frenzie Frenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine to merge @benoit-pierre? (Conflict-wise I mean.)

@benoit-pierre
Copy link
Contributor

Yes.

@poire-z poire-z merged commit 99a6bd1 into koreader:master May 20, 2024
2 checks passed
@poire-z poire-z deleted the bump_crengine branch May 20, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants