Fix ruby alignment, fix one possible crash, ignore empty non-linear flows #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coding error: images with width=0 in tables/floats would cause an infinite loop and a stack overflow.
If a non-linear flow was created, but we never got any "line" associated to it, just ignore it and reset the counter. (Otherwise, frontend would get holes/nil in the array of flows, and would get confused.)
So frontend can build this bit of text and propagate it to crengine for it to display in place of its own computed text.
This was referenced May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
html5.css: really ensure ruby centering
Should allow closing koreader/koreader#11771.
getRenderedWidths(): fix possible crash with 0-width images
Coding error: images with width=0 in tables/floats would cause an infinite loop and a stack overflow.
Should allow closing koreader/koreader#11680
Page splitting: ignore empty non-linear flows
If a non-linear flow was created, but we never got any "line" associated to it, just ignore it and reset the counter.
(Otherwise, frontend would get holes/nil in the array of flows, and would get confused.)
Fix issue noticed at koreader/koreader#8623 (comment).
LvDocView header: allow overriding "page/total %"
So frontend can build this bit of text and propagate it to crengine for it to display in place of its own computed text.
Will allow KOReader (via ReaderCoptListener) to display something similar to what it displays in the footer (which is different from crengine's own text when using hidden flow or reference page numbers).
This change is