mupdf: fix shared library permissions #1818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure it's executable, so `bindeps` & `libcheck` targets don't ignore it.
|
Didn't we have a discussion about not making them executable? (I'm not trying to state any particular preference.) |
Frenzie
approved these changes
Jun 11, 2024
|
It's not the default on Debian, and lintian complains about it. |
|
In principle it doesn't seem to make much sense to set it as executable if the result isn't anything useful, in any case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure it's executable, so
bindeps&libchecktargets don't ignore it.This change is