mupdf: fixes #1821
Merged
mupdf: fixes #1821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pre-update to 1.24.2, MuPDF would return `(0, 0)` when the position cannot be resolved, but the new version returns `(NaN, NaN)` instead, which breaks backward compatibility.
We still need the patch to `fz_new_base14_font` (from 22a6e4f, dropped in 3f00257) as `fz_encode_character_with_fallback` will call it as last resort if our fallback (`FreeSerif`) font does not contain the required character. Additionally, rework the whole `NOBUILTINFONT` patch: simplify so the number of stubs can be reduced.
Frenzie
approved these changes
Jun 12, 2024
Frenzie
pushed a commit
to koreader/koreader
that referenced
this pull request
Jun 13, 2024
Commodore64user
pushed a commit
to Commodore64user/KOReader_fork
that referenced
this pull request
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework external fonts patch to fix second variant of koreader/koreader#11959.
Fix
mupdf_fz_resolve_linkbackward incompatible change when link position cannot be resolved: don't return(NaN, NaN).This change is