Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing build dependency for Debian (and probably Ubuntu) #10896

Closed
mytskine opened this issue Sep 13, 2023 · 3 comments · Fixed by #10897
Closed

Missing build dependency for Debian (and probably Ubuntu) #10896

mytskine opened this issue Sep 13, 2023 · 3 comments · Fixed by #10897
Assignees
@Frenzie
Labels
documentation
Milestone
2023.10

Comments

@mytskine
Copy link
Contributor

  • KOReader version: master
  • Device: PC with Debian testing

Issue

Building fails at the lilzmq step with the message:

autogen.sh: error: could not find libtool.  libtool is required to run autogen.sh.

Steps to reproduce

Follow the official guide to build koreader:

sudo apt install build-essential git patch wget unzip \                                                     
    gettext autoconf automake cmake libtool nasm ragel luarocks lua5.1 libsdl2-dev \
    libssl-dev libffi-dev libsdl2-dev libc6-dev-i386 xutils-dev linux-libc-dev:i386 zlib1g:i386
./kodev fetch-thirdparty
./kodev build

Solution

Add libtool-bin to the required dependencies.
@NiLuJe
Copy link
Member

NiLuJe commented Sep 13, 2023

Was libtool kicked out of build-essentials? (Or whatever the base "I need to build stuff" set is actually named... Oh, how I love binary distros...)

@Frenzie
Copy link
Member

Frenzie commented Sep 13, 2023

@NiLuJe It was never in build-essentials; that's just a shortcut for gcc, g++, make and like two or three packages of header files. You'll note it says libtool right in between cmake and nasm in that line. ;-)

Anyway, this is indeed an oversight in the README, and a very old one to boot it would seem. koreader/virdevenv#26

@Frenzie Frenzie added this to the 2023.09 milestone Sep 13, 2023
@Frenzie Frenzie self-assigned this Sep 13, 2023
Frenzie added a commit that referenced this issue Sep 13, 2023
@Frenzie
[doc] Building: minor updates to Debian/Ubuntu prerequisites
0188b97 
libtool-bin is something everyone already has installed so it slipped by unnoticed for more than half a decade.

SDL 1.2 support was removed 4 years ago: koreader/koreader-base#963

Fixes #10896.
@Frenzie Frenzie mentioned this issue Sep 13, 2023
Merged
@Frenzie
Copy link
Member

Frenzie commented Sep 13, 2023

As stated there, it's because of the mesozoic libzmq we're using.

https://github.com/zeromq/libzmq/pull/1497

Frenzie added a commit that referenced this issue Sep 14, 2023
@Frenzie
[doc] Building: add libtool-bin to Debian/Ubuntu prerequisites as a w…
1f03e76 
…orkaround for ancient libzmq (#10897)

Fixes #10896.

It's because of an extremely old version of libzmq, fixed since <zeromq/libzmq#1497>.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Frenzie Frenzie

Labels
documentation
Projects
None yet
Milestone
2023.10
3 participants
@NiLuJe @Frenzie @mytskine