Building: add libtool-bin to Debian/Ubuntu prerequisites as a workaround for ancient libzmq #10897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libtool-bin is something everyone already has installed so it slipped by unnoticed for more than half a decade. SDL 1.2 support was removed 4 years ago: koreader/koreader-base#963 Fixes #10896.
NiLuJe
approved these changes
Sep 14, 2023
Frenzie
commented
Sep 14, 2023
| @@ -22,8 +22,8 @@ Install the prerequisites using APT: | |||
|
|
|||
| ``` | |||
| sudo apt-get install build-essential git patch wget unzip \ | |||
| gettext autoconf automake cmake libtool nasm ragel luarocks lua5.1 libsdl2-dev \ | |||
| libssl-dev libffi-dev libsdl2-dev libc6-dev-i386 xutils-dev linux-libc-dev:i386 zlib1g:i386 | |||
There was a problem hiding this comment.
I was more tired yesterday than I thought. I somehow read sdl2 as sdl12 xD
There was a problem hiding this comment.
Er, though I just realized it's in there twice so removing it was the correct call by accident. 🤦
Frenzie
changed the title
Frenzie
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libtool-bin is something everyone already has installed so it slipped by unnoticed for more than half a decade.
SDL 1.2 support was removed 4 years ago: koreader/koreader-base#963Fixes #10896.
This change is