-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kodev build fails under Fedora 26 #3069
Comments
You could always use https://github.com/koreader/virdevenv instead, but that sounds like there's something wrong with either the linker or a compiler. Notice how it says Could any of that be the problem? (e.g., missing g++) |
You could always use https://github.com/koreader/virdevenv instead, but that
sounds like there's something wrong with either the linker or a compiler.
This looks to me more complicated than doing a non-virtual build. But
thanks for the hint, might look into this if I don't succeed with the
normal build.
Notice how it says |"CC=\"/usr/bin/ccache gcc\" CXX=\"/usr/bin/ccache g++\"|
Could any of that be the problem? (e.g., missing g++)
No, both are properly installed, running either
/usr/bin/ccache gcc --version
or
/usr/bin/ccache g++ --version
manually results in no error.
|
And Edit: that is, something like |
Not sure how I would execute
here is the part of the config log that shows the error in more detail |
But you're conspicuously leaving out all of the environment variables in that case. ;-) Like I implied, I'd be particularly suspicious of something in this one: Heck, I wrote that before even actually looking at the log and it's confirmed:
A quick search for that error combined with Fedora yields this.
|
Sorry, I did not do this intentionally. To me those files often look more like noise than like signal.
The error translates to: "All warnings are treated as errors". I manually deleted the string Anyway, after doing this,
|
You don't need any translations unless you wish to test in another language (wie Deutsch).
It's actually exactly what they did upstream. We'll have to look into bumping that. Also, here's an argument against it https://blog.flameeyes.eu/2009/02/future-proof-your-code-dont-use-werror/ The easiest option would be just to add -Wnoerror without changing anything else, something I've done before. |
`new_lang` isn't `en_US` but `en_US:en` Also see #3069 (comment)
Sorry, I got distracted by the translation thing. Could you share the debug output? |
Sure, here you go. About the translation: I did not ask for German translation files but it somehow looks for them (maybe because my locale is set to de_DE?) |
That's correct. I'm guessing you're missing SDL? A Debian package name like
I think KOReader locale is wholly independent from the system locale. Either way it doesn't matter because it simply falls back to the built-in (English) strings. |
Oh, yes. That's true. Luckily for me this isn't the only error because otherwise you could have just relied RTFM.
Package
It's nowadays |
Ah yes, I should've expected that. See #2798 (comment) Your easiest bet is to install Lua 5.1. On Debian I can pick between 5.1, 5.2, 5.3 or all of 'em. If that's not possible I mentioned an ugly hack in my link as well as the proper way to go about it.
Keine Ahnung. :-P Was ist anders? |
Okay, there is no dedicated lua-5.1 under fedora, only the binaries (
Oh, they just rewrote it from scratch I think and everything is supposed to be better in |
Well, hopefully I'll remember the next time I try a Fedora Live |
So, I managed to compile the koreader emulator under fedora now (see linked pull request), but it still fails to start. Installing lua5.1 seems to not so easy to do under fedora1, I successfully scrambled up my system's lua by compiling and installing lua5.1 manually. I reverted that and tried the hack, you mentioned @Frenzie (changing 5.1 to 5.3 in
So, I'm trying the 1 imo that's fine; quote from http://www.lua.org/versions.html#5.1
|
Like I said in my linked comment, compiling your own probably shouldn't be too problematic as the Travis builds do just that already: Lines 25 to 31 in 96ea2ec
That aside, LuaJIT2.1-beta3 (the version I just recently bumped it to) has a lot more 5.2 stuff, so that might both work and not even be half as inadvisable as it used to be. |
Fixes koreader#3069 * [fix] compile errors under Fedora due to -Werror (koreader/koreader-base#500)
Fixes koreader#3069 and koreader#3116. * [fix] compile errors under Fedora due to -Werror (koreader/koreader-base#500)
okay. Since I'm not familiar with the lua... ...jit, ...rocks, ...younameit world, I need some clarifications:
|
You can stick it wherever you want as long as it's in Edit: relevant parts from Travis script and kodev: Lines 64 to 69 in 96ea2ec
Lines 563 to 566 in 7284ad4
|
Fixes #3069 and #3116. * [fix] compile errors under Fedora due to -Werror (koreader/koreader-base#500)
I give up on this. I compiled and installed luajit systemwide (with no specific CMAKE_INSTALL_PREFIX). koreader starts but this time really crashes:
Speicherzugriffsfehler is a segmentation fault. My gut says this has something to do with too much lua stuff on my PC. Anyway, I got a running emulator using the virtual machine. it takes way longer to compile but it runs, so I'm happy for now. |
Issue
In the process of creating a plugin (to be able to disable touch with a physical button on the inkbook prime, stay tuned), I wanted to build koreader but failed to do so.
I'm running Fedora 26 and think that I do have all necessary requirements (lua, nasm, ...)
This is what I did:
And here is the output from
./kodev build -v
. It fails at configuring djvulibre. Manually going into that directory and doing.\configure && make
works, though.The text was updated successfully, but these errors were encountered: