-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect north east/west arrows in Noto font #4707
Closed
Labels
Comments
Frenzie
added a commit
to Frenzie/koreader
that referenced
this issue
Mar 2, 2019
NB The north east and north west arrows are swapped, see koreader#4707
Frenzie
added a commit
that referenced
this issue
Mar 2, 2019
NB The north east and north west arrows are swapped, see #4707
There was an update of the various Google maps fonts a while ago, I'll try
to remember to check/ship that ;).
(could you assign this to me, still on mobile ;)).
…On Sat, Mar 2, 2019, 13:23 Frans de Jonge ***@***.***> wrote:
- KOReader version: master
Issue
North east and north west arrows are swapped in the Noto font.
Take these symbols:
northeast = "⬈", -- U+2B08 NORTH EAST BLACK ARROW
northwest = "⬉", -- U+2B09 NORTH WEST BLACK ARROW
southeast = "⬊", -- U+2B0A SOUTH EAST BLACK ARROW
southwest = "⬋", -- U+2B0B SOUTH WEST BLACK ARROW
Only the bottom two are displayed in the correct direction.
Pinging @NiLuJe <https://github.com/NiLuJe> who knows more about the font.
(For the diagonal multiswipes it doesn't really matter. I can just swap
the symbols with a comment.)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4707>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAG1ZrA6CGeR65yT6Wyo0e6ULEB1Xoq4ks5vSm1FgaJpZM4baWqb>
.
|
The culprit is actually FreeSerif, Noto doesn't have those glyphs at all ;). |
I didn't investigate, but I did notice they didn't seem to match up. :-P |
NiLuJe
added a commit
to NiLuJe/koreader-fonts
that referenced
this issue
Mar 4, 2019
Relevant to our interests, fixes diagonal arrows (fix koreader/koreader#4707). Caveat: No new releases since 2012, I had to rebuild them from sources from the latest SVN revision (r3988, https://savannah.gnu.org/svn/?group=freefont). I switched to the OTF variant while I was there. Without changing the file extension to avoid duplicates when upgrading. The Makefile warns about poetnail issues with Arabic kerning when built with current FontForge version (which I did, as I used a build based on today's sources). As we currently don't support RTL anywhere, meh. Rebuild FreeFont w/ a CJK-aware FontConfig build, just in case. Probably irrelevant.
Frenzie
pushed a commit
to koreader/koreader-fonts
that referenced
this issue
Mar 4, 2019
Relevant to our interests, fixes diagonal arrows (fix koreader/koreader#4707). Caveat: No new releases since 2012, I had to rebuild them from sources from the latest SVN revision (r3988, https://savannah.gnu.org/svn/?group=freefont). I switched to the OTF variant while I was there. Without changing the file extension to avoid duplicates when upgrading. The Makefile warns about poetnail issues with Arabic kerning when built with current FontForge version (which I did, as I used a build based on today's sources). As we currently don't support RTL anywhere, meh. Rebuild FreeFont w/ a CJK-aware FontConfig build, just in case. Probably irrelevant.
Frenzie
added a commit
to Frenzie/koreader
that referenced
this issue
Mar 5, 2019
Fixes koreader#4743 (shallow submodule + GitHub bug). Updated FreeSans fixes koreader#4707 todo (swapped arrows).
Merged
Frenzie
added a commit
that referenced
this issue
Mar 5, 2019
mwoz123
pushed a commit
to mwoz123/koreader
that referenced
this issue
Mar 29, 2020
…#4710) NB The north east and north west arrows are swapped, see koreader#4707
mwoz123
pushed a commit
to mwoz123/koreader
that referenced
this issue
Mar 29, 2020
Fixes koreader#4743 (shallow submodule + GitHub bug). Updated FreeSans fixes koreader#4707 todo (swapped arrows).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue
North east and north west arrows are swapped in the Noto font.
Take these symbols:
Only the bottom two are displayed in the correct direction.
Pinging @NiLuJe who knows more about the font.
(For the diagonal multiswipes it doesn't really matter. I can just swap the symbols with a comment.)
The text was updated successfully, but these errors were encountered: