Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Option for shutdown in the Gesture Manager #5021

Closed
noembryo opened this issue May 10, 2019 · 10 comments · Fixed by #5225
Closed

Feature request: Option for shutdown in the Gesture Manager #5021

noembryo opened this issue May 10, 2019 · 10 comments · Fixed by #5225
Assignees
Milestone

Comments

@noembryo
Copy link
Contributor

noembryo commented May 10, 2019

Just a way to avoid a click or two by long pressing a corner :-p

I never put my Glo to sleep, because if I do, it spends more battery than when is open.
So I have to shutdown every time I leave my book.
And I'm lazy...

On a side-note, would it not be cleaner if there was a menu arrangement like this?

Gesture Manager
    Top left corner
        Tap
            menu
        Hold
            menu
    Top right corner
        Tap
            menu
        Hold
            menu
    Bottom left corner
        Tap
            menu
        Hold
            menu
    Bottom right corner
        Tap
            menu
        Hold
            menu

Anyway, all these are minor nitpicks.
You guys have made KOReader a super reader!

Too bad there is no windows version ;o)

@noembryo
Copy link
Contributor Author

noembryo commented May 11, 2019

I meant "Hold" not "Right tap" ..

@Frenzie
Copy link
Member

Frenzie commented May 14, 2019

Too bad there is no windows version ;o)

I'm told the program runs fine in WSL.

@noembryo
Copy link
Contributor Author

What is WSL (apart from that WSL)

@robert00s
Copy link
Contributor

Should we reorganize Gesture manager menu or leave as it is? I like arrangement as is now.

@Frenzie
Copy link
Member

Frenzie commented Aug 18, 2019

I think it's clearer to have the tap menu with locations, the hold menu, etc. (like we do). To focus on the location first rather than the action strikes me as backwards, but I'm having trouble articulating why.

@poire-z
Copy link
Contributor

poire-z commented Aug 18, 2019

I think it's clearer to have the tap menu with locations (like we do)

I agree,
Couldn't we just move the 4 Tap y x corner in a Tap corner > submenu, like all the others?
It woule make the main menu one single page.
And the Tap y x corner ones are the only ones not (yet) showing the associated action in parenthesis in the menu text. Adding that while they are in the main menu would make that main menu a bit ugly, but no pb if they are moved in a submenu.

@noembryo
Copy link
Contributor Author

@Frenzie So, is the "Shut down reader" added to the gesture manager options?

@Frenzie
Copy link
Member

Frenzie commented Aug 18, 2019

It was added a few days ago in #5202.

@noembryo
Copy link
Contributor Author

Oops, I missed it... :o)
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants