Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OPDS Catalog Removal crash #5091

Closed
TinfoilSubmarine opened this issue Jun 25, 2019 · 2 comments · Fixed by #5092
Closed

OPDS Catalog Removal crash #5091

TinfoilSubmarine opened this issue Jun 25, 2019 · 2 comments · Fixed by #5092
Labels
bug
Milestone
2019.07

Comments

@TinfoilSubmarine
Copy link

  • Version: 2019.06
  • Device: Kobo Glo HD

When trying to remove default OPDS catalogs (specifically ManyBooks, Internet Archive, Flibusta (Russian), textos.info (Spanish)), there is a crash as soon as "Delete" is pressed.
@Frenzie Frenzie added the bug label Jun 25, 2019
@Frenzie
Copy link
Member

Frenzie commented Jun 25, 2019

Interestingly, this only happens if you already removed a few of them previously (or perhaps also if you added something). On a clean install this can't be reproduced.

@Frenzie
Copy link
Member

Frenzie commented Jun 25, 2019

PS The crash.log file is really quite useful. I could've seen the problem without having the program available then. ;-)

If there are fewer than 4 servers, this line will crash:

koreader/frontend/ui/widget/opdsbrowser.lua

Lines 92 to 93 in a791a7d

elseif servers[4].title == "Internet Archive" and servers[4].url == "http://bookserver.archive.org/catalog/" then
servers[4].url = "https://bookserver.archive.org"

Frenzie added a commit to Frenzie/koreader that referenced this issue Jun 25, 2019
@Frenzie
[fix] OPDS crash with fewer than 4 servers
1f1a7f6 
Regression introduced in <koreader#4249>.

Fixes <koreader#5091>.
@Frenzie Frenzie added this to the 2019.07 milestone Jun 25, 2019
@Frenzie Frenzie mentioned this issue Jun 25, 2019
Merged
Frenzie added a commit that referenced this issue Jun 25, 2019
@Frenzie
[fix] OPDS crash with fewer than 4 servers (#5092)
fca5175 
Regression introduced in <#4249>.

Fixes <#5091>.
mwoz123 pushed a commit to mwoz123/koreader that referenced this issue Mar 29, 2020
@Frenzie @mwoz123
[fix] OPDS crash with fewer than 4 servers (koreader#5092)
c0070cf 
Regression introduced in <koreader#4249>.

Fixes <koreader#5091>.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2019.07
Development

Successfully merging a pull request may close this issue.

[fix] OPDS crash with fewer than 4 servers Frenzie/koreader
2 participants
@Frenzie @TinfoilSubmarine