Page flipping mode & Bookmark browsing mode: messy?

[gerhaher]

• KOReader version: v2019.08-39-ga2dcfe9_2019-08-23/
• Device: KA1

Issue

I never use them myself so maybe I've missed something... but they seem to be mixed up with each other.

When you go into page flipping mode the bookmark browsing mode box gets ticked. And you can only untick it by leaving page flipping mode.

On the other hand, if you go into bookmark browsing mode you can leave that mode with your chosen toggle page flipping gesture. But when you do that it looks like you can't get into page flipping mode again. It has trouble to find right zoom ("Zoom to fit page").

[gerhaher]

Better, but not 100 % correct yet.

If I tick the Bookmark browsing mode box I can untick it with a Page flipping mode gesture.

[Frenzie]

In what sense is that not correct?

[Frenzie]

I mean, what would you expect it to do instead?

[gerhaher]

But aren't those two different features?

https://github.com/koreader/koreader/wiki/Tips-and-Tricks

I just find it strange that if you want to use Bookmark browsing mode you open the menu and tick that box. And when you end it you can use a gesture that belongs to something else (Page flipping mode).

[Frenzie]

It's more like a variation with slightly different controls than an entirely different mode. It's arguably obsolete since you can use page flipping + skim to, although then you have a dialog obscuring the action. Personally I much prefer the skim to dialog for any kind of flipping because it gives you precise controls, with the "page flipping mode" mostly being useful to quickly switch back & forth between full page view.

But sure, alternatively this here could just say return to do nothing, or instead get rid of the return to disable bookmark flipping and properly enter page flipping mode without potential weird interactions.

koreader/frontend/apps/reader/modules/readerpaging.lua

Lines 276 to 278 in a9f2481

	if self.bookmark_flipping_mode then
	self:onToggleBookmarkFlipping()
	return