Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inverted page turns not initialized properly #5346

Closed
hgrain86 opened this issue Sep 9, 2019 · 5 comments · Fixed by #5350
Closed

Inverted page turns not initialized properly #5346

hgrain86 opened this issue Sep 9, 2019 · 5 comments · Fixed by #5350
Labels
bug
Milestone
2019.09.2

Comments

@hgrain86
Copy link

hgrain86 commented Sep 9, 2019 •
edited

  • KOReader version: V1-09-2019
  • Device: kobo aura one

Issue: I cant find (right to left) option in the last update! it was very useful for me when i read arabic books :(
@poire-z
Copy link
Contributor

poire-z commented Sep 9, 2019

It has been moved to another menu: Gear > Navigation > Invert page turn taps and swipes (#5284).

@hgrain86
Copy link
Author

hgrain86 commented Sep 9, 2019

It has been moved to another menu: Gear > Navigation > Invert page turn taps and swipes (#5284).

It does not work properly on kobo aura one
I need to activate it every time i want to read the book
then When I do this new option crashes a lot of other features
like bookmarks and select text ............
I apologize for the poor language I do not speak English and I use Google translator to communicate
thanks a lot.

@Frenzie Frenzie changed the title I cant find (right to left) option in the last update! Inverted page turns not initialized properly Sep 9, 2019
@Frenzie Frenzie added bug and removed question labels Sep 9, 2019
@Frenzie
Copy link
Member

Frenzie commented Sep 9, 2019 •
edited

I must've made a mistake if it's not loading the setting properly, but what's this about bookmarks not working and crashing?

Could you please attach the crash.log as it is after a crash?

@Frenzie Frenzie added this to the 2019.09.2 milestone Sep 9, 2019
Frenzie added a commit to Frenzie/koreader that referenced this issue Sep 9, 2019
@Frenzie
[fix] ReadSettings Inverse reading order
00633a3 
`self.inverse_reading_order == nil and G_reader_settings:has("inverse_reading_order")` wouldn't be true in case of per document settings, which would then falsely default to false.

Fixes <koreader#5346>.
@Frenzie Frenzie mentioned this issue Sep 9, 2019
Merged
Frenzie added a commit that referenced this issue Sep 9, 2019
@Frenzie
[fix] ReadSettings Inverse reading order (#5350)
ed43968 
`self.inverse_reading_order == nil and G_reader_settings:has("inverse_reading_order")` could easily be false, which would then incorrectly turn the setting off.

Fixes <#5346>.
@hgrain86
Copy link
Author

hgrain86 commented Sep 9, 2019

Now after the update the problem seems to be solved but you can not bookmark the book after activating the option (invert page turn.....) until you restart the program
thanks a lot

@Frenzie
Copy link
Member

Frenzie commented Sep 9, 2019

Confirmed, but it's an old(er) issue, not a regression in 2019.09.

@Frenzie Frenzie mentioned this issue Sep 9, 2019
Closed
mwoz123 pushed a commit to mwoz123/koreader that referenced this issue Mar 29, 2020
@Frenzie @mwoz123
[fix] ReadSettings Inverse reading order (koreader#5350)
0fc6933 
`self.inverse_reading_order == nil and G_reader_settings:has("inverse_reading_order")` could easily be false, which would then incorrectly turn the setting off.

Fixes <koreader#5346>.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2019.09.2
Development

Successfully merging a pull request may close this issue.

[fix] ReadSettings Inverse reading order Frenzie/koreader
3 participants
@Frenzie @poire-z @hgrain86