-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash on emulator startup (./kodev run) on macOS 10.15.1 #6873
Comments
What's your system language? This doesn't look related to macOS (a welcome change :-P) but I can't quite tell what the problem might be. Basically the output of these commands: echo $LANGUAGE
echo $LC_ALL
echo $LC_MESSAGES
echo $LANG With any luck it should be reproducible anywhere. |
Nice. Those above where empty, setting $LANG helped. |
@Witos I'd still like to figure out the root cause. ;-) |
Without setting anything manually (and you might have to clear settings too), does something like this output anything? diff --git a/frontend/gettext.lua b/frontend/gettext.lua
index 85e3f9fb..d0a4da12 100644
--- a/frontend/gettext.lua
+++ b/frontend/gettext.lua
@@ -167,6 +167,8 @@ end
-- we only implement a sane subset for now
function GetText_mt.__index.changeLang(new_lang)
+print("new_lang", new_lang)
+error()
GetText.context = {}
GetText.translation = {}
GetText.current_lang = "C"
|
Tested:
|
What exactly did you set |
I unset it.
|
But what did you set it to when you set it? |
Thanks, I think I know the issue thanks to that. Could you please try this? diff --git a/frontend/gettext.lua b/frontend/gettext.lua
index 85e3f9fb..92c7c081 100644
--- a/frontend/gettext.lua
+++ b/frontend/gettext.lua
@@ -23,6 +23,7 @@ local isAndroid, android = pcall(require, "android")
local logger = require("logger")
local GetText = {
+ context = {},
translation = {},
current_lang = "C",
dirname = "l10n", |
In case of no environment language. I suppose that doesn't tend to happen much in the wild since I added the offending code early in 2020. ;-) Fixes <koreader#6873>.
Works with LANG unset. Thanks! |
In case of no environment language. I suppose that doesn't tend to happen much in the wild since I added the offending code early in 2020. ;-) Fixes <#6873>.
v2020.10.1-47-g1468646a_2020-11-13
macOS 10.15.1 (Macbook)
Issue
./kodev run crashes on startup
Steps to reproduce
export PATH="/usr/local/opt/gettext/bin:${PATH}"
export MACOSX_DEPLOYMENT_TARGET=10.14
./kodev run
Attaching log from the run.
crash.log
The text was updated successfully, but these errors were encountered: