ReaderHighlight: manage overlapped highlights #10492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poire-z
approved these changes
May 27, 2023
Comment on lines
+851
to
+852
| function ReaderHighlight:showChooseHighlightDialog(highlights) | ||
| if #highlights == 1 then |
There was a problem hiding this comment.
(The name of this method is about what happens in the else branch - so it may better have a more generic name. But can't really think of any, a generic showHighlightsDialog() is a bit misleading too. So, ok :)
Frenzie
added a commit
to Frenzie/koreader
that referenced
this pull request
Jun 9, 2023
The problem stems from <koreader#10492> but we need the translations to go through.
Frenzie
added a commit
that referenced
this pull request
Jun 9, 2023
The problem stems from <#10492> but we need the translations to go through.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tapping a highlighted fragment that belongs to several (overlapped) highlights will call a popup menu that allows to choose a desired highlight.
4 highlights, 2 of them with notes:
Closes #10482.
This change is