New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kindle: Log the suspend/wakeup source (& a bunch of fixes) #11350
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @NiLuJe)
If you ping me after merge i will check what this is when triggered by a rtc wakeup. (If i remember it might be null) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @NiLuJe)
9602693
to
f763932
Compare
We currently don't do anything with it, but this might help someone come up with fancier smartcover handling, like we do on Kobo... Simplify the fake events w/args checks: We can just hitcheck the table directly, no need for another hash Also catch ExitedSS on Kindle. And, again, dn't do anything with it ;p.
Sorry, the |
Delay anything that attempts to destroy the current document instance if we're inside an event handler. Re: koreader#11147 (comment)
That might not make it through unscathed, as EDIT: Oh, wait, we have a bit of time before it'll become a problem, at which point timekeeping in its entirety will be broken on those platforms anyway :D. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 3 files at r3, 5 of 5 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @NiLuJe)
If you give me a few minutes, i will test this. rebuilding now. |
curl refuses to build with:
|
archlinux has autoconf 2.72, which breaks curls configure script generation. downgrading to 2.71 fixes it for now |
some notes for anyone interested |
|
*border* That's going to be the sneaky bug to beat for 2024, lol ;). Fix koreader#11357
Huh, good to know, so does Gentoo. I'll see if I can fudge that tomorrow ;). (I was building the input module manually to test, FWIW). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @NiLuJe)
-- this falls outside of the ges_events range of a VirtualKey, so it is *NOT* caught by VK. | ||
-- Instead, since we're flagged is_always_active, it goes to us, | ||
-- so we'll have to double check that it wasn't inside of the whole VK region, | ||
-- otherwise tapping inside a border would close the VK ;p. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that was annoying.
We currently don't do anything with it, but this might help someone come up with fancier smartcover handling, like we do on Kobo...
Requires koreader/koreader-base#1723
This change is