Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18n] Font UI fallbacks: insert replacement characters with template for Weblate compatibility #11614

Merged
merged 1 commit into from Apr 3, 2024

Conversation

Frenzie
Copy link
Member

@Frenzie Frenzie commented Apr 3, 2024

Added in #8722 and unproblematic for the past two years, but Weblate has now decided to complain about it to the extent of disabling translations:

Error message
String contains control character: 'If some book titles, dictionary entries and such are not displayed well but shown as \ufffe\ufffe or ��, it may be necessary to download the required fonts for those languages. They can then be enabled as additional UI fallback fonts.\nFonts for many languages can be downloaded at:\n\nhttps://fonts.google.com/noto\n\nOnly fonts named "Noto Sans xyz" or "Noto Sans xyz UI" (regular, not bold nor italic, not Serif) will be available in this menu. However, bold fonts will be used if their corresponding regular fonts exist.'


This change is Reviewable

…ibility

Added in <koreader#8722> and unproblematic for the past two years, but Weblate has now decided to complain about it to the extent of disabling translations:

> Error message
String contains control character: 'If some book titles, dictionary entries and such are not displayed well but shown as \ufffe\ufffe or ��, it may be necessary to download the required fonts for those languages. They can then be enabled as additional UI fallback fonts.\nFonts for many languages can be downloaded at:\n\nhttps://fonts.google.com/noto\n\nOnly fonts named "Noto Sans xyz" or "Noto Sans xyz UI" (regular, not bold nor italic, not Serif) will be available in this menu. However, bold fonts will be used if their corresponding regular fonts exist.'
@Frenzie Frenzie added the i18n label Apr 3, 2024
@Frenzie Frenzie added this to the 2024.04 milestone Apr 3, 2024
Fonts for many languages can be downloaded at:

https://fonts.google.com/noto

Only fonts named "Noto Sans xyz" or "Noto Sans xyz UI" (regular, not bold nor italic, not Serif) will be available in this menu. However, bold fonts will be used if their corresponding regular fonts exist.]])
Only fonts named "Noto Sans xyz" or "Noto Sans xyz UI" (regular, not bold nor italic, not Serif) will be available in this menu. However, bold fonts will be used if their corresponding regular fonts exist.]]), "￾￾", "��")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PS This GH preview doesn't show them.

image

@Frenzie Frenzie changed the title [i18n] Insert replacement characters with template for Weblate compatibility [i18n] Font UI fallbacks: insert replacement characters with template for Weblate compatibility Apr 3, 2024
@Frenzie Frenzie merged commit b9261e0 into koreader:master Apr 3, 2024
1 of 2 checks passed
@Frenzie Frenzie deleted the weblate-control-chars branch April 3, 2024 15:55
Frenzie added a commit to koreader/koreader-translations that referenced this pull request Apr 3, 2024
Frenzie added a commit to koreader/koreader-translations that referenced this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant