Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sleep screen wording fixes #11647

Merged
merged 5 commits into from
Apr 9, 2024
Merged

Conversation

Commodore64user
Copy link
Contributor

@Commodore64user Commodore64user commented Apr 9, 2024

fixing minor issues with #11549

Bug: There appears to be a problem with the edit sleep screen message setting, as it shows the older version of the description (not the new and improved Enter a custom message to be displayed on the sleep screen. The following escape sequences are available:, see image attached

IMG_5443

but I can't see why. it was working fine on my kindle 5 testing machine.

@Frenzie if you are not happy with the change, change it back, I promise I won't meddle anymore.


This change is Reviewable

@Frenzie
Copy link
Member

Frenzie commented Apr 9, 2024

Thanks, that'll save me some effort later.

To be clear, I'd love to use Wake-up screen delay. I much prefer it for obvious reasons. However… while for 5 seconds the distinction wouldn't much matter, the difference between the device being awake waiting for a tap and sleeping can be quite significant (as in hours of battery drainage). That's why I'm insisting on the concept of after waking up. That is, something along the lines of Postpone screen update after waking up, Postpone/delay changing screen after waking up, Screen refresh delay on/after wake-up, etc. to avoid suggesting that the actual waking up itself is delayed.

Bug: There appears to be a problem with the edit sleep screen message setting, as it shows the older version of the description (not the new and improved Enter a custom message to be displayed on the sleep screen. The following escape sequences are available:, see image attached

You probably just forgot to update the relevant file? Unless you're getting a "dirty" (suggested, marked for edit, should be unused in the UI) translation from the British English localization, which would indeed be a bug. In any case I just updated it over on Weblate, so if that was the case tomorrow it'll be worked around.

@hius07
Copy link
Member

hius07 commented Apr 9, 2024

description = _([[
Enter a custom message to be displayed on the sleep screen. The following escape sequences are available:

It's good.

@Frenzie Frenzie added this to the 2024.04 milestone Apr 9, 2024
@Frenzie
Copy link
Member

Frenzie commented Apr 9, 2024

PS I translated it in Dutch as Schermupdate uitstellen na ontwaken (Postpone screen-update after awakening) which sounds significantly better than the English original, even though word for word it's identical.

@Commodore64user
Copy link
Contributor Author

You probably just forgot to update the relevant file?

I did no such thing.

Unless you're getting a "dirty" (suggested, marked for edit, should be unused in the UI) translation from the British English localization, which would indeed be a bug. In any case I just updated it over on Weblate, so if that was the case tomorrow it'll be worked around.

although I didn't have a [any] language ticked, selecting English (not UK) did in fact solve the issue. So it appears it is a bug with the English (UK) "translation" malarkey.

@Frenzie
Copy link
Member

Frenzie commented Apr 9, 2024

So it appears it is a bug with the English (UK) "translation" malarkey.

I can confirm that it is. Not with English (UK) of course; all translations are affected.

@Commodore64user
Copy link
Contributor Author

To be clear, I'd love to use Wake-up screen delay. I much prefer it for obvious reasons. However… while for 5 seconds the distinction wouldn't much matter, the difference between the device being awake waiting for a tap and sleeping can be quite significant (as in hours of battery drainage). That's why I'm insisting on the concept of after waking up. That is, something along the lines of Postpone screen update after waking up, Postpone/delay changing screen after waking up, Screen refresh delay on/after wake-up, etc. to avoid suggesting that the actual waking up itself is delayed.

well there was this #11598 recently, which would be a nice addition to solving that issue, just a thought.

Frenzie added a commit to Frenzie/koreader that referenced this pull request Apr 9, 2024
@Frenzie Frenzie merged commit fb86aca into koreader:master Apr 9, 2024
1 of 3 checks passed
@Commodore64user Commodore64user deleted the sleep-screen-fixes branch April 9, 2024 10:55
Frenzie added a commit that referenced this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants