Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make: improve appimageupdate rule, take 2 #11671

Merged

Conversation

benoit-pierre
Copy link
Contributor

@benoit-pierre benoit-pierre commented Apr 11, 2024

The FUSE detection is false positive under Gitlab's pipeline, so just use the hidden --appimage-extract-and-run option to automatically and always "extract & run" the appimage tool.

Cf. #11669 (comment).


This change is Reviewable

The FUSE detection is false positive under Gitlab's pipeline,
so just use the hidden `--appimage-extract-and-run` option to
automatically and always "extract & run" the appimage tool.
@Frenzie
Copy link
Member

Frenzie commented Apr 11, 2024

Yup, that's what I was thinking.

@Frenzie Frenzie merged commit ad6607c into koreader:master Apr 11, 2024
1 of 3 checks passed
@Frenzie Frenzie added this to the 2024.04 milestone Apr 11, 2024
@benoit-pierre benoit-pierre deleted the pr/improve_appimageupdate_rule,_take_2 branch April 11, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants