Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update tool to generate metadata translations #11869

Merged
merged 9 commits into from
May 26, 2024

Conversation

pazos
Copy link
Member

@pazos pazos commented May 21, 2024

Updated:

  • strings to translate.
  • english metadata

Added:

  • appstream: metadata generator
  • appstream: translation of screenshot captions, if they're present.
  • appstream: link to gh release notes

This change is Reviewable

@pazos pazos marked this pull request as draft May 21, 2024 17:36
@pazos pazos force-pushed the generic_metadata branch 2 times, most recently from b614cee to cd6f8bd Compare May 25, 2024 10:45
@pazos pazos mentioned this pull request May 25, 2024
@pazos pazos requested a review from Frenzie May 25, 2024 11:09
tools/update-metadata.lua Outdated Show resolved Hide resolved
tools/update-metadata.lua Outdated Show resolved Hide resolved
tools/update-metadata.lua Outdated Show resolved Hide resolved

<recommends>
<memory>1024</memory>
<display_length compare="ge">600</display_length>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like the good old kobo touch / kobo mini.

tools/update-metadata.lua Outdated Show resolved Hide resolved
tools/update-metadata.lua Outdated Show resolved Hide resolved
@pazos pazos changed the title wip: update tool to generate metadata translations update tool to generate metadata translations May 25, 2024
@pazos pazos marked this pull request as ready for review May 25, 2024 16:56
Copy link
Member

@Frenzie Frenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@pazos pazos merged commit 3fb2f18 into koreader:master May 26, 2024
3 checks passed
@pazos pazos deleted the generic_metadata branch May 26, 2024 18:10
@Frenzie Frenzie added this to the 2024.06 milestone May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants