Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: improve metadata #11829

Open
pazos opened this issue May 15, 2024 · 67 comments
Open

FR: improve metadata #11829

pazos opened this issue May 15, 2024 · 67 comments

Comments

@pazos
Copy link
Member

pazos commented May 15, 2024

We're currently in two different app stores.

The metadata needs some love.

It differs between both stores. Summary and description need to be improved.

  • The summary should be something short like "Document viewer", "Ebook reading app" or "Ebook reading platform" or any other suggestion.

  • The description can be longer but it isn't possible to cover what the app does, so we need to highlight some features.

The snapshots need a caption related to the action you're seeing in the picture.

So, I'm asking for

  • app summary
  • app description
  • app screenshot topics and relevant captions
@Frenzie
Copy link
Member

Frenzie commented May 16, 2024

My preference would be "ebook reader" or "document viewer".

For the description, I'd say we take from "multi-format documents" and "full-featured reading" in the readme, when we previously went over this in detail.

@pazos
Copy link
Member Author

pazos commented May 16, 2024

Thanks for the feedback, @Frenzie. I mostly agree with that.

I would like an opinion from our UX focused people @offset-torque and @Commodore64user:

Could you take a look at https://github.com/koreader/koreader/blob/master/metadata/en-US/full_description.txt?

I assume the part that says it is portable or it is optimized for eink devices is not that important in the description. The rest of highlights seem relevant. Is somebody able to summarize that into a couple of paragraphs?

Strong opinions are encouraged here :)

Also, if you are unaware, english is not my forte. I wouldn't mind to have something to copy/paste :D

@shuvashish76
Copy link

Automated screenshots for Android: https://docs.fastlane.tools/getting-started/android/screenshots/

@offset-torque
Copy link

I actually expanded the linked text from the guide's "What can you do with KOReader?" section. We have some newer very useful and unique features. So I am writing this as a base to modify.

I am trying to think as a user searching an "ebook reader" (I agree with Frenzie, this is exactly what I would search) on F-droid. Most important things would be probably:

  • Is it optimized for e-ink?
  • What formats can it open?
  • Is it easy to read PDFs?
  • Can I highlight and export?

Here is the expanded text. First three items answers the questions above so I consider them important. You, Frenzie and Commodore64user can pick and join/add/subtract the parts as you like:

  • Custom UI without animation which is optimized for e-ink devices. Night Mode and screen light/warmth support.

  • Support for both fixed page formats (PDF, DjVu, CBT, CBZ) and reflowable e-book formats (EPUB, FB2, Mobi, DOC, CHM, TXT, HTML). Scanned PDF/DjVu documents can also be reflowed. Special flow directions for reading double column PDFs and mangas.

  • Special multi-page highlight mode with many online/local export options. Powerful gesture system and ability to create your own menus.

  • Multi-lingual user interface with a highly customizable reader view with complete typesetting options. Multi-lingual hyphenation dictionaries are bundled in.

  • Integrated with Calibre (search metadata, receive ebooks wirelessly, browse library via OPDS), Wallabag, Wikipedia, Google Translate and other content providers.

  • Unique Book Map and other widgets to overview and navigate your book. Detailed reading statistics.

  • Look up words with StarDict dictionaries / Wikipedia, add your own online OPDS catalogs and RSS feeds, online over-the-air self update, an FTP client and SSH server to transfer your books wirelessly, cloud storage support.

@Commodore64user
Copy link
Contributor

Commodore64user commented May 16, 2024

  • Is it optimized for e-ink?
  • What formats can it open?
  • Is it easy to read PDFs?
  • Can I highlight and export?

As a kindle man, there is one more think I would like to know (assuming I was trying to find an alternative to it):

  • Can I synchronise my progress across my devices?

I like these a lot, I would only change:

  • Custom UI without animation which is optimized for e-ink devices. Night Mode, screen light/warmth support.

Custom UI without animations, optimized for e-ink devices. Night Mode, screen light and warmth support.

  • Support for both fixed page formats (PDF, DjVu, CBT, CBZ) and reflowable e-book formats (EPUB, FB2, Mobi, DOC, CHM, TXT, HTML). Scanned PDF/DjVu documents can also be reflowed. Special flow directions for reading double column PDFs and mangas.

Support for both fixed page formats (PDF, DjVu, CBT, CBZ) and reflowable e-book formats (EPUB, FB2, Mobi, DOC, CHM, TXT, HTML). Scanned PDF/DjVu documents can also be reflowed. Special flow directions for reading double column PDFs and manga.

  • Multi-lingual user interface with a highly customizable reader view with complete typesetting options. Multi-lingual hyphenation dictionaries are bundled in.

Multi-lingual user interface with a highly customizable reader view and advanced typesetting options. Multi-lingual hyphenation dictionaries are bundled in.

  • Integrated with Calibre (search metadata, receive ebooks wirelessly, browse library via OPDS), Wallabag, Wikipedia, Google Translate and other content providers.

Deep integration with Calibre (search metadata, receive ebooks wirelessly, browse library via OPDS), Wallabag, Wikipedia, Google Translate and other content providers also supported.

what is that about creating your own menus? can we do that?

last but not least (I actually don't know how it works so correct me if wrong)

  • Synchronise your progress across all your devices running KOReader using our own sync server or host your own.

not quite happy with it but I'll think about it and edit it if I can think of a better way of phrasing it.

@pazos
Copy link
Member Author

pazos commented May 16, 2024

Thank you!

I'm totally ok with #11829 (comment), just a few nitpicks:

screen light/warmth support.

That's hardware, it might not be available on a particular device or platform. It might not be supported on a specific device even when it is supported on others of the same platform.

online over-the-air self update, an FTP client and SSH server to transfer your books wirelessly

These features are not very relevant here. OTA updates are provided by the stores themselves, so not our feature.
In both android and linux there're better alternatives for an FTP client. The SSH server is not supported in there.

The rest looks good, specially with bullet points :)

@offset-torque
Copy link

@pazos
Yeah sure, please change them as necessary. I forgot about the platforms while writing that (sleep deprivation :)

Coincidentally last week I started making some screenshots for the main page showing our new features.

I think app screenshots for the stores can be like this list (and I can prepare them):

  • Reading page (with some nicely formatted book and an informative status/progress bar)
  • Bottom "text formatting menu collage" to show all the advanced customization options
  • A book page with different highlight and note indicator types
  • Book map
  • Page browser
  • (Maybe) History or Favorites
  • (Maybe) Reading progress

I think showing these features is important because there are many reader apps on F-Droid and some of them are just simple wrappers around a PDF library or a very basic EPUB reader. Our informative (and cool) screenshots would help differentiate KOReader from these simpler apps.


@Commodore64user
Your changes are good.

what is that about creating your own menus? can we do that?

Yep, with our Quick Menu

@Commodore64user
Copy link
Contributor

what is that about creating your own menus? can we do that?

Yep, with our Quick Menu

ahh, yes. I do have one of those.

@pazos
Copy link
Member Author

pazos commented May 17, 2024

I think app screenshots for the stores can be like this list (and I can prepare them)

That would be amazing :)

We currently ship 3 sizes.

  • phone (1080x1920), used by fdroid
  • generic (1404x1872), used by koreader.rocks
  • desktop with window decoration (2000x1398), used by flathub

Slightly different sizes shouldn't be a problem as long as the ratio is preserved.

It is totally ok to use the emulator to make all the snapshots. Try to follow https://docs.flathub.org/docs/for-app-authors/metainfo-guidelines/quality-guidelines/#default-settings but feel free to change DPI settings for different form factors.

some nicely formatted book

Public domain, CC or similar license, please :)
Extra points if it is something you can get from within KO (wikipedia, opds, wallabag, news...):)

(Maybe)

There's room for 6-10, so feel free to pick the relevant ones from your list or add others.

It seems quite a job to recreate meaninful data on the emulator just to showcase advanced widgets as they deserve :)

@shuvashish76
Copy link

shuvashish76 commented May 17, 2024

Suggestion ideas for Android Screenshots

some nicely formatted book

Public domain, CC or similar license, please :)

Pick books from Gutenberg, which has all the books as public domain. Only download the books that has some nice cover images so that we can show them in KOReader "History" & Favorites" screenshots.

KOReader

Screenshot Texts Comments
1 Dark theme support - Front screenshot: white theme, - Back screenshot: Dark theme. Both taken from the same reader page, with no top or bottom page view. This is to show clean interface.
2 Highlights and Notes Show one of the Note popup message while the reader page in background with some highlights, underlines, strikethrough etc.
3 Bottom Menu Always show white theme screenshot on top for better visibility
4 Book map, Page Browser I think Book map has many things to show so it should be shown as Top screenshot & the Page browser behind it
5,6 History, Favorites Since we've Collection feature now I think better to show Favourite &or Collection on top screenshot and History screenshot behind it
7,8 Reading Statistics Show Reading Progress on top as it has more details, Calendar view behind it
9 RSS News One of the following...wikipedia, opds, wallabag, news

As background image of all the screenshot we can use some public domain image.

There's room for 6-10, so feel free to pick the relevant ones from your list or add others.

Just a mock-up idea to fit as many useful features in these 10 screenshots.

BTW F-Droid docs suggests to use featureGraphic.png. I think we can use the graphics what we use in releases (cropped as landscape 1024x500)

@Frenzie
Copy link
Member

Frenzie commented May 17, 2024

One of the following...wikipedia, opds, wallabag, news

I probably wouldn't pick the newsreader. On anything but an ereader there are many choices. I suppose you don't really need Wikipedia integration there either but in any case that's properly nice, especially the saved EPUB articles.

Nice comment btw, thanks. 👍

@poire-z
Copy link
Contributor

poire-z commented May 17, 2024

(I'm probably in the minority, but I quite hate these fancy presentations with parts of the screen covered, and some tilted - give me real horizontal full view screenshots and I'm happier. But it's your thing :))

If this targets Android, another question is: should the "model" be a phone (like in the presentation above), or an eReader looking device (with a more 4/3 aspect ratio). I think we target eInk devices better, than plain and tall Android phones, where our monochromatic glory may not be really appreciated, and a good amount of phone-only users will just hate it.

@pazos
Copy link
Member Author

pazos commented May 17, 2024

(I'm probably in the minority, but I quite hate these fancy presentations with parts of the screen covered, and some tilted - give me real horizontal full view screenshots and I'm happier. But it's your thing :))

Agree 100%.

If this targets Android, another question is: should the "model" be a phone (like in the presentation above), or an eReader looking device (with a more 4/3 aspect ratio). I think we target eInk devices better, than plain and tall Android phones, where our monochromatic glory may not be really appreciated, and a good amount of phone-only users will just hate it.

We target phones as good as eink readers :)
Anything with HiDPI below 8" is our forte :). The problem arises with non-hiDPI displays on desktop computers, big tablets or even huge eink devices.

The autoDPI setting doesn't scale well, so desktop users might want to set DPI to 90/100 (it really depends on the DE) and big tablet users might want something like 110-130.

But, yeah: the screenshots are handled by fastlane and cover phone and tablet images. In theory both will be picked if present and the one relevant to the device is displayed. Any e-ink (or not eink) tablet should use the tablet images if it was built correctly (hint: they're not)

We currently only ship phone images, so including tablet images could be a nice addition.

@shuvashish76
Copy link

I'm probably in the minority, but I quite hate these fancy presentations with parts of the screen covered, and some tilted - give me real horizontal full view screenshots and I'm happier.

Actually I don't like them either, I like minimalist useful screenshots. From what I've seen majority of people like fancy designs...I might be wrong as we target F-Droid users not PlayStore.

I think we target eInk devices better, than plain and tall Android phones, where our monochromatic glory may not be really appreciated, and a good amount of phone-only users will just hate it.

I agree. F-Droid docs suggests sevenInchScreenshots, tenInchScreenshots in different directories. So it should be picked up shown to relevant devices only.

@pazos
Copy link
Member Author

pazos commented May 17, 2024

Automated screenshots for Android: https://docs.fastlane.tools/getting-started/android/screenshots/

Thanks for the hints. Unfortunately we can't use it as it relies in a view hierarchy we don't implement.

Not sure if it worth the hussle to script screenshot creation, specially if we stay with a few untranslated screenshots.

@shuvashish76
Copy link

My idea was to add multiple screenshots to condensed under 10 but as there is no such limitations to show max10 screenshots we can use 10+ most useful features show as real separate horizontal full view screenshots :) Only limitation for F-Droid is "500 characters for changelogs" which is not relevant for KOReader.

@pazos
Copy link
Member Author

pazos commented May 17, 2024

My idea was to add multiple screenshots to condensed under 10 but as there is no such limitations to show max10 screenshots we can use 10+ most useful features show as real separate horizontal full view screenshots :)

Please don't :)

The restriction comes from https://docs.flathub.org/docs/for-app-authors/metainfo-guidelines/quality-guidelines/#at-least-one-screenshot

To prevent maintainer nightmares in the future it is useful to keep the same metadata everywhere, so lets use that 6-10 limit for screenshots. They should also cover the same stuff, with the same settings across diferent devices resolutions.

@offset-torque
Copy link

@pazos
I will use Alice's Adventures in Wonderland in screenshots, which is also the standard book of our guide screenshots. It is available on Gutenberg and OPDS, in public domain and it is a neutral book (with interesting text). Also I have seen some other reader projects using it in their screenshots so I guess everyone likes Alice.

Some questions:

  • Why do we need this: "generic (1404x1872), used by koreader.rocks". I guess this is for emulating an e-ink reader, probably that is one of Kindle's screen resolutions. Right?
  • Flathub resolution is "2000x1400 for HiDPI" on that page. You wrote 1398. Why is that tiny 2 pixel difference?
  • Do we have a deadline for this?

@shuvashish76 please look at the image below. This is your image and green area shows the pixels that belong to real screenshot areas.

carousel

According to this, you want us to allocate more than 60% of our available screenshot area to a world map instead of the user interface of our application. Why? How this benefits users? How taking a full size screenshot and scaling down and rotating it to make them less readable help users. This is form over function, just a fancy marketing carousel. Problem is we are not selling anything. Users will want to see what the program looks like, and we don't have the luxury to throw away those pixels.

  • If you look at the linked Flathub quality guidelines you will see they agree with this. Actually your image can be used as a "Do not do these!" example in their guidelines. I am quoting: "Do not include the wallpaper behind the app. Do not edit the screenshot, crop it, add text, or include promotional graphics." Since we will be submitting there too, I will make all our screenshots consistent with this. They will just have different aspect ratios for the relevant platforms.
  • Setting aside the usability concerns, it won't even look good. Our interface is monochrome and it is ugly. Because it has to be ugly to be usable on e-ink devices. Because of this, anything you put around the screenshots will visually dominate them and just create clutter, instead of making them look nicer. Black and white lines can't compete with any image.
  • F-droid interface is extremely simple too. Just 4-5 images side-by-side. There is no hero image like Play Store, nor a fancy carousel. All this effort for nothing.

@shuvashish76
Copy link

Users will want to see what the program looks like, and we don't have the luxury to throw away those pixels.

Thanks, nothing to disagree here. Besides all the points you mentioned, this is the perfect reason not use such designs 👍🏿

@pazos
Copy link
Member Author

pazos commented May 17, 2024

Why do we need this: "generic (1404x1872), used by koreader.rocks". I guess this is for emulating an e-ink reader, probably that is one of Kindle's screen resolutions. Right?

Yup, HiDPI e-ink reader 3:4 ratio.

Flathub resolution is "2000x1400 for HiDPI" on that page. You wrote 1398. Why is that tiny 2 pixel difference?

Because that's what I've got trying to reach flathub specs :). As I said a few pixels more or less shouldn't hurt as long as the ratio is mostly the same.

Do we have a deadline for this?

Nope. Screenshots can wait as long as we want. The text needs to be updated ASAP to be included in our translation pipeline.

The thing I will need to figure out is how to add these beautiful bullet points in each store while keeping the sentences straight for translation.

For text we're currently using https://github.com/koreader/koreader/blob/master/tools/update-metadata.lua#L15-L31
Screenshots go on https://github.com/koreader/koreader-artwork, except for the fdroid screenshots that go in https://github.com/koreader/koreader/tree/master/metadata/en-US/images

My plan, for the long run, is to update the script so it fetches translations and pulls screenshots from the artwork repo. Then it is a matter of calling it once a year or so to keep both things updated.

@offset-torque
Copy link

The thing I will need to figure out is how to add these beautiful bullet points in each store while keeping the sentences straight for translation.

I can:

  • Take my base text above
  • Apply the proposed changes here
  • Simplify and polish the sentences for publishing and translation

By the way here is a Flathub page of a nice reader called Foliate that I used before.
Our features will look like this, just a bit longer:

https://flathub.org/apps/com.github.johnfactotum.Foliate


For screenshots, I have to create a workflow because probably I will have to make around 40-50 images in different resolutions and text appearance/dpi settings (including feedbacks, revisions, updates etc.).

@pazos
Copy link
Member Author

pazos commented May 17, 2024

Yep, flathub works with html <ul>'s. The problem is fdroid. I couldn't find a single app that's using bullet points on its description or anything else that shows some style beyond plain text. If you find one please share it here :)

@Frenzie
Copy link
Member

Frenzie commented May 17, 2024

I searched for list and it somehow just worked out. xD
https://f-droid.org/en/packages/uk.sensoryunderload.infinilist/

@pazos
Copy link
Member Author

pazos commented May 17, 2024

Great, that shows it is possible. Now if I could figure out where the metadata is stored...

Not on github: https://github.com/fredx100/InfiniList
Fdroid repo has the manifest: https://gitlab.com/fdroid/fdroiddata/-/blob/master/metadata/uk.sensoryunderload.infinilist.yml but seems to lack metadata in https://gitlab.com/fdroid/fdroiddata/-/tree/master/metadata?ref_type=heads

@shuvashish76
Copy link

shuvashish76 commented May 17, 2024

@pazos
Copy link
Member Author

pazos commented May 17, 2024

Thank you very much @shuvashish76 :)

So it is <ul>s there too.

By looking at flathub in Deutsch https://flathub.org/de and Español https://flathub.org/es it looks like there's no translated metadata. Or at least not used in there.

Appstream supports translations but it isn't clear how they're wrapped up into apps (a single appstream.xml?, one per language?), so I'm going to leave flathub untranslated for the moment. If somebody figures out how it is expected to work it should be trivial to translate them using the same F-Droid metadata.

@pazos
Copy link
Member Author

pazos commented May 17, 2024

the mpv for app-store metadata would be:

Document Viewer

KOReader is an ebook reader built from the ground up for e-ink devices.

Features:

  • Support for both fixed page formats (PDF, DjVu, CBT, CBZ) and reflowable e-book formats (EPUB, FB2, Mobi, DOC, CHM, TXT, HTML). Scanned PDF/DjVu documents can also be reflowed. Special flow directions for reading double column PDFs and manga.

  • Multi-lingual user interface with a highly customizable reader view and advanced typesetting options. Multi-lingual hyphenation dictionaries are bundled in.

  • Integrated with Calibre (search metadata, receive ebooks wirelessly, browse library via OPDS), Wallabag, Wikipedia, Google Translate and other content providers.

Is that ok? @Frenzie @poire-z @shuvashish76 @offset-torque @Commodore64user?

Do you miss some other bullet point? Do you want to change some expression?

I'm not sure between "Features:" or "Some features" or "Highlights" or "Some highlights".

@Commodore64user
Copy link
Contributor

Commodore64user commented May 17, 2024

I would change this: KOReader is an open source ebook reader built from the ground up for e-ink devices. with a custom user interface and optimized for e-ink devices.

I would also use the bullet points as I wrote them (i am biased), and please tell me that i can synchronise my progress with all my devices.

Do you miss some other bullet point? Do you want to change some expression?

Yes, see above. I want to know that i can start reading on kobo (well not me) and continue on Android just where i left off. I also want to be told in small print that a wifi connection is required ;), and batteries not included in the box.

I'm not sure between "Features:" or "Some features" or "Highlights" or "Some highlights".

Features is fine, i think.

@shuvashish76
Copy link

Current short_description : Ebook reader with support for many formats like PDF, DjVu, EPUB, FB2, CBZ

IMO we don't need to mention formats here as already mentioned on full_description, it's just to get the initial impression about the software.
Suggestion: A full-featured Ebook reader with highly customizable features.

@jonnyl2
Copy link
Contributor

jonnyl2 commented May 18, 2024

document viewer or ebook reader?

My vote is for "ebook reader". Document viewer gives the wrong impression IMO. (I'd use a "document viewer" to take a quick glance at a document, not to spend serious time on it. I'd also not expect a document viewer to leave metadata-traces on disk after opening a file.)

@pazos
Copy link
Member Author

pazos commented May 18, 2024

Thank you all for all your feedback!

Changes in text metadata for appimage/flathub can be reviewed in the link above.

Changes in text metadata for f-droid will happen on different stages.

  1. Lets wait a couple of weeks and see the changes reflected in https://flathub.org/apps/rocks.koreader.KOReader. During that time people can still suggest changes.
  2. Push the english version to f-droid and setup the strings for translation.
  3. Localized versions will remain on the old metadata for 4-6 months to give time to translators.

Screenshots and screenshot's captions are welcome at any time :)

@yparitcher
Copy link
Member

I have hebrew text (with diacritics) screenshots on my website https://kindleseforim.paritcher.com/

If you would like a different size, i should be able to generate them.

@offset-torque
Copy link

@yparitcher we will have screenshots in different scripts (Latin, Hebrew, Arabic, Russian, Chinese, Japanese and Korean) so it will look more professional if all of them have the same UI and similar text appearance settings. I think it would be much less effort for me (and everyone included) to generate these screenshots myself instead of coordinating these 3 different device settings with 7 different users and having feedbacks and retakes if necessary.

But you can help me with this, since I was going to ask in this thread:

  • A nice, readable Hebrew font. I see you have SBL on your website. Is this the best font for reading Hebrew on an e-reader? I found around 50 Hebrew fonts on Google Fonts and ~15 of them looks usable on an e-reader. (Also your suggestion will be added to the user guide's recommended fonts section, so it would be better if this font is available on Google Fonts website)
  • A public domain Hebrew book that is not religious nor political, something like a well known novel. Otherwise this will open the door to same demands for other scripts and our screenshots might end up like a theology curriculum.

@yparitcher
Copy link
Member

yparitcher commented May 19, 2024

Some background:

For Hebrew there are 2 types of books that one can be reading. 1. Typeset in modern Hebrew or 2. Typeset in biblical Hebrew.

modern Hebrew generally does not use Nikkud (diacritics) so

  1. It only really needs RTL support, and not many advanced typesetting features (even with the bottom menu font kerning set to off or good looks fine)
  2. Many fonts & font styles (more sans or serif) look good and are used.

Biblical Hebrew can make heavy use of nikkud.
(This is a major simplification, as it depends on which book, and what type of print.) This

  1. requires much more use of the advanced kerning (must be set to best).
  2. Also only works with a smaller subset of fonts with proper support (and which mostly tend to follow the vilna font style).

All Hebrew reader should be able to read both (they are not separate type systems), and even modern hebrew can use nikkud to disambiguate identically typed words.

Now my (subjective :) opinion, as one who primarily reads Jewish texts in Hebrew.

  1. SBL Hebrew is a good font to recommend (esp. for books) as it a traditional style, is easy to read, and it has very good support for all hebrew features.
    For periodicals etc. some may be used to a more sans font but then again fonts are very subjective.

  2. I do not know of public domain modern Hebrew works, but you can take a Hebrew wikipedia article for example, however i do not think that this will do justice to our Hebrew support, as it only highlights a very small portion of what we can do, (which is the easy part that many other programs can do also, even kindle stock).
    I do believe that we should use a book with nikkud in the screenshots as this really illustrates how koreader shines, and is where other programs fall apart (for example stock kindle just puts the nikkud dots all over the page.)
    You can see this difference between the 2 screenshots on my website, one has nikkud one doesn't.

If we can find a neutral book with nikkud great (i will take a quick look), however i do believe that most of them that will be found will be religous texts.

@offset-torque
Copy link

Thanks for the informative reply yparitcher.

I do believe that we should use a book with nikkud in the screenshots as this really illustrates how koreader shines, and is where other programs fall apart (for example stock kindle just puts the nikkud dots all over the page.)

I totally agree with this. We are trying to showcase the capabilities of KOReader. Now we have a valid justification for it, we can use the religious texts. I installed the SBL font, I agree that it looks more elegant than modern sans fonts. And I can see the nikkud move to their correct places with the kerning in KOReader set to BEST.

I downloaded the Seforim archive file from your website. Which file/page do you suggest for the screenshots?

@yparitcher
Copy link
Member

I would say the first page of בראשית.epub in the chumah rashi folder. (That is the beginning of Genesis in the bible, so the most basic book.)

If you want a second one i would say try the mishna.

Ty

@Commodore64user
Copy link
Contributor

I don't know what "nikkud" means, but don't take the religious route (no offence to anyone). There is just no valid reason to go that way. You would just be alienating users.

@pazos
Copy link
Member Author

pazos commented May 19, 2024

I don't know what "nikkud" means, but don't take the religious route (no offence to anyone). There is just no valid reason to go that way. You would just be alienating users.

Not taking a religious route is a religious stance ;)

I wouldn't mind people reading all kind of books with this software, including religious ones. But none of the languages
included in "Non-Latin script support for books, including the Hebrew, Arabic, Persian, Russian, Chinese, Japanese and Korean languages" deserves positive discrimination and there's no screenshots enough to cover them all.

So I would say: stay with english only ebooks that are available under a non restrictive license an let people using non-latin scripts to trust us a bit, install the application and read whatever they want.

@yparitcher
Copy link
Member

yparitcher commented May 19, 2024

If there are only enough screenshots for english, so be it.
However i do believe it may be possible to showcase some of the other writing systems as that is a big advantage of koreader, (at least one CJK screenshot, and one RTL screenshot)

@pazos
Copy link
Member Author

pazos commented May 19, 2024

If there are only enough screenshots for english, so be it. However i do believe it may be possible to showcase some of the other writing systems as that is a big advantage of koreader, (at least one CJK screenshot, and one RTL screenshot)

I really don't know what's the best option :/

Maybe we can add a new test epub that showcases RTL and CJK in a single document and use that in a single screenshot?

@offset-torque
Copy link

I don't know what "nikkud" means

These marked dots and lines. Correct positions in green:
nikkud

I mean if we can do something correctly that even Kindles fail, this is a big deal.

Commodore64user - There is just no valid reason to go that way. You would just be alienating users.

Best solution is to find a neutral text with these special cases I agree, but do they exist I don't know.


yparitcher - However i do believe it may be possible to showcase some of the other writing systems as that is a big advantage of koreader, (at least one CJK screenshot, and one RTL screenshot)

pazos - Maybe we can add a new test epub that showcases RTL and CJK in a single document and use that in a single screenshot?

Yes, I was thinking of combining the screenshots so it wouldn't be very crowded. One split for RTL (Hebrew+Arabic) and one for CJK scripts maybe. So 2 extra screenshots to show that we are adept at rendering many other scripts sounds reasonable to me.

I really don't know what's the best option :/

I agree. I don't have strong opinions about this topic so I will go with the consensus here. For now I will start with the English ones, we will come to a decision in the meantime.

@Frenzie
Copy link
Member

Frenzie commented May 20, 2024

Simply sticking 2 or 3 RTL languages in one screenshot is also what I was going to suggest.

You could also do something really dumb, like:

برخی از متن که به زبان فارسی است، اما من فارسی صحبت نمی کنم، بنابراین من برخی از انگلیسی به فارسی با استفاده از گوگل ترجمه، ترجمه شده است. من کاملا مطمئنم که ترجمه واقعا افتضاح است

@pazos
Copy link
Member Author

pazos commented May 24, 2024

Appstream supports translations but it isn't clear how they're wrapped up into apps (a single appstream.xml?, one per language?), so I'm going to leave flathub untranslated for the moment. If somebody figures out how it is expected to work it should be trivial to translate them using the same F-Droid metadata.

Just got some spare time and dig a bit o the topic.

Flathub metadata isn't translated on the webpage but both gnome-software and plasma-discover can use translations if they're present.

Translations go on the same xml file, with a xml:lang tag, for instance:

<summary>Ebook reader</summary>
<summary xml:lang="es">Lector de libros electrónicos</summary>

So, everything is translatable :)

Which leads me to the next question, @Frenzie @poire-z: Do we have some xml tools to do these kind of tasks (ie: editing xml files in place or keep a representation as a lua table and dump it to an xml file on demand)?

Or do I need to read the whole file, line by line, and append each translated line for each translated category for each translated language?

@poire-z
Copy link
Contributor

poire-z commented May 24, 2024

(No idea nor experience about these topics :/ sorry.)

@Frenzie
Copy link
Member

Frenzie commented May 24, 2024

Do we have some xml tools to do these kind of tasks (ie: editing xml files in place or keep a representation as a lua table and dump it to an xml file on demand)?

Err, there's an XML parser hidden away in NewsDownloader I think if that helps whatever you're thinking of.

@pazos
Copy link
Member Author

pazos commented May 25, 2024

Thank you. I ended up writing xml manually as part of #11869.
It is a bit ugly but at least there aren't many lines of code :)

@Frenzie
Copy link
Member

Frenzie commented May 25, 2024

You might want to preemptively escape &&amp;, <&lt;, >&gt; in case they're added in the future.

Also see https://github.com/koreader/crengine/blob/33d7fcc097aebd3b2fa10325814417619ba804bd/.ci/script.sh#L27-L31

@pazos
Copy link
Member Author

pazos commented May 25, 2024

I don't aim at xml validation, only appstream validation:

appstreamcli validate koreader.metainfo.xml
I: rocks.koreader.KOReader:4: cid-maybe-not-rdns rocks.koreader.KOReader
I: rocks.koreader.KOReader:7: developer-name-tag-deprecated
I: rocks.koreader.KOReader:25: relation-memory-in-requires
W: rocks.koreader.KOReader:117: invalid-iso8601-date %%DATE%%
I: rocks.koreader.KOReader:~: developer-info-missing

✘ Falló la validación: alertas: 1, información: 4, redundante: 4

The warning is expected as goes away on flatpak/appimage builds.

@Frenzie
Copy link
Member

Frenzie commented May 25, 2024

I don't aim at xml validation, only appstream validation:

My assumption is that malformed XML will make appstream go 💀

@pazos
Copy link
Member Author

pazos commented May 25, 2024

There's no problem, AFAICT.

We keep the metadata in a lua table and generate the xml from there. Most of it is untranslated in a big [[]] string and the things that are generated programatically are translations that append xml:lang= to the specific xml element we're trying to translate.

If you see I missing something lets move conversation to #11869 :)

@pazos
Copy link
Member Author

pazos commented May 25, 2024

@shuvashish76

Whatever the description maybe...my point is keyword specific search is the only option to discover if you never heard about the relevant app (in this case hidden gem KOReader)...we've to use most important keywords from the users prospective.

ebook, reader, PDF, EPUB, TXT, manga, Kindle, Kobo, PocketBook, Calibre, e-ink, highlight, dictionar, plugin, animation (users searching for no animation), Wallabag, Wikipedia, metadata, gesture? RSS? News?, Statistics?, Profiles?, Vocabulary?

That's particulary true on flatpak/flathub, which follows FreeDesktop specs and lacks a category for "reading". So, currently we're in two additional categories ("viewer" and "literature") but not a main one. That means a category search won't place KO in any of the categories supported by stores that deal with flatpak.

But flatpak let us specify keywords, which can be translated.

So a subset of the keywords you highlighted above would be great. Not many to avoid being a spammy mess. For instance I do believe our support for wikipedia is good enough to add wikipedia as a keyword. I don't think the same about translate. Probably particular apps, such as calibre, wallabag, readwise or google translate, don't deserve a keyword as we're just confusing users that look for a different piece of software.

Here are some I think they're ok as keywords.

  • reader
  • multilingual
  • dictionary
  • wikipedia
  • ebook
  • epub
  • annotations
  • reflow
  • browser
  • downloader

Any other suggestions?

tl;dr: In order for KO to appear in a linux app store the user needs to search by its name. With keywords the app can be listed on queries like "epub reader", "multilingual dictionary" or "wikipedia downloader"

@Frenzie
Copy link
Member

Frenzie commented May 25, 2024

Probably particular apps, such as calibre, wallabag, readwise or google translate, don't deserve a keyword as we're just confusing users that look for a different piece of software.

The Wallabag plugin is also quite good fwiw.

Any other suggestions?

Definitely PDF and DjVu, those are main formats, probably also FB2.

  • browser

browser?

@pazos
Copy link
Member Author

pazos commented May 25, 2024

browser?

as in File browser. Nvm, deleted it :)

Definitely PDF and DjVu, those are main formats, probably also FB2.

good

The Wallabag plugin is also quite good fwiw.

Ok, added.

More keywords can be added on the future but we shouldn't include words that are going to be removed soon.

BTW, I think file formats shouldn't be translated.

For now I have:

  <keywords>
    <keyword>reader</keyword>
    <keyword>viewer</keyword>
    <keyword>dictionary</keyword>
    <keyword>wikipedia</keyword>
    <keyword>wallabag</keyword>
    <keyword>annotations</keyword>
    <keyword>epub</keyword>
    <keyword>fb2</keyword>
    <keyword>pdf</keyword>
    <keyword>djvu</keyword>
  </keywords>

@pazos
Copy link
Member Author

pazos commented May 25, 2024

As for the main categories it doesn't seem flathub imposes them: https://docs.flathub.org/docs/for-app-authors/metainfo-guidelines/#categories-and-keywords

But having one shouldn't hurt. Sadly, without "Reading", the best fit is either "Education" or "Office" and none of them stay close to reading :/

@offset-torque
Copy link

In KDE software center all document viewers, EPUB reading/editing utilities etc. are under the Office category. Flathub category can be Office too to keep them in sync.

@Frenzie
Copy link
Member

Frenzie commented May 25, 2024

Okular is in graphics and office
calibre is in office

So while it sounds a bit weird I imagine we should simply follow that example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants