Font menu: add symbols for default and fallback fonts #3941
Conversation
Also allows for updating the fallback font and see results in real-time on the underlying document. Also adds a menu item to generate a html document showing some sample text rendered with each available font.
|
That reminds me that I should probably update our bundled fonts to the latest Noto release ;). |
| text = text .. " ★" | ||
| end | ||
| if v == fallback_font then | ||
| text = text.." ♻" |
There was a problem hiding this comment.
Not much choice with what's available in Noto fonts (including the updated ones, seen no other symbols than the ones I'm used to).
test_unichars.html.txt : sample file where I do my icon shopping.
There was a problem hiding this comment.
There's a (couple of) relatively small NotoSymbols fonts that we could pull if you fancy something in there... ;).
Getting the relevant menu entry to use them over the default UI font might get tricky, though...
There was a problem hiding this comment.
I guess we should be fine with what we have.
Btw, the greek glyphs have been corrected in your updated Noto Sans CJK, and they have also been included in the main Noto Sans, so good idea to update them :)
|
Alternate solution with less dark symbols (the blank square aiming at representing a missing glyph :): |
|
I kinda prefer the filled, dark star. Not quite convinced about the blank square, but I don't hate it ;). |
|
I also prefer the dark star |
|
As suggested by @Frenzie in #3942 (comment) :) and looks OK if we stay with filled/dark symbols:
|
|
The fallback character? That makes quite a bit of sense actually, but it was just a joke about the open book thing.
|
|
Oh, it displayed as that in my browser :) |
|
I could update the message displayed when Hold, to somehow explain the symbols. Any preference for where the symbols should be (in the text or in the buttons)? |
|
Probably in the text between parentheses. Visually I prefer it in the buttons, but that might lead to space issues in some translations. |
|
That would give this (with a non-break space before the opening parentheses, that isn't distinguished from a classic space in github code view): |
|
Yes, I think that makes it clear that it's parenthetical information. |
| text = _("Generate fonts test html document"), | ||
| callback = function() | ||
| UIManager:show(ConfirmBox:new{ | ||
| text = _("Would you like to generate a html document showing some sample text rendered with each available font?"); |
TouchMenu: added options to menu items with the following defaults:
keep_menu_open = false
hold_keep_menu_open = true
So, default for Tap callback is to close menu, and for Hold callback
to keep menu open.
In both cases, provide the TouchMenu instance as the 1st argument to
the callback functions (instead of a refresh_menu_func I added in koreader#3941)
so the callback can do more things, like closing, refreshing,
changing menu items text and re-ordering...
ReaderZooming: show symbol for default (like it was done for
ReaderFont, ReaderHyphenation...)
TextEditor plugin: update the previously opened files list in real
time, so the menu can be kept open and used as the TextEditor main
interface.
SSH plugin: keep menu open and update the Start/Stop state in real time
ReadTimer plugin: tried to do what feels right (but I don't use it)
TouchMenu: added options to menu items with the following defaults:
keep_menu_open = false
hold_keep_menu_open = true
So, default for Tap callback is to close menu, and for Hold callback
to keep menu open.
In both cases, provide the TouchMenu instance as the 1st argument to
the callback functions (instead of a refresh_menu_func I added in #3941)
so the callback can do more things, like closing, refreshing,
changing menu items text and re-ordering...
ReaderZooming: show symbol for default (like it was done for
ReaderFont, ReaderHyphenation...)
TextEditor plugin: update the previously opened files list in real
time, so the menu can be kept open and used as the TextEditor main
interface.
SSH plugin: keep menu open and update the Start/Stop state in real time
ReadTimer plugin: tried to do what feels right (but I don't use it)
Also remove forgotten cp in the move/paste file code
Adds symbols for default and fallback fonts.
Also allows for updating the fallback font and see results in real-time on the underlying document.
Also adds a menu item to generate a html document showing some sample text rendered with each available font.
(our default fallback font Noto Sans CJK has wrong glyphs for greek, so it's nice being able to see how others do - will need a base bump for koreader/crengine#186 for real-time update).
I recently came across https://poliseuse.wordpress.com/ (in french) which has reviews for many fonts and their use on ereaders - and I like testing fonts :)
I used to manually make some html document with the same text displayed with each font, so I can more easily (than with changing fonts with the menu) compare fonts.
With this new set of fonts to test, I thought that koreader could as well build that html document instead of me manually :)
So, this new menu item will display only if the user has a file
koreader/settings/fonts-test-sample.htmlwith some HTML snippet of his choice (*), and will generate a file in the home directory namedfonts-test-all.html, that will allow comparing all fonts with the help of koreader features (Skim to widget, swipe to go to latest bookmarks...):(*) dunno if this is a sufficiently interesting feature to have us add a default
fonts-test-sample.htmlwith some koreader blablah (sufficiently long so one can see paragraphs, wraps, line-height...), and some words/texts of various alphabets, CJK, links, superscripts, subscripts, numbers, italic... but if yes, feel free to write it :)