WebDav CloudStorage #4272
WebDav CloudStorage #4272
Conversation
Addition of WebDav to the CloudStorage. The functionality is the same as with Dropbox and FTP, it is possible to browse the files on the server and download a copy. Tested with: NextCloud HubZilla
| @@ -88,6 +89,15 @@ function CloudStorage:selectCloudType() | |||
| end, | |||
| }, | |||
| }, | |||
| { | |||
| { | |||
| text = _("WebDav"), | |||
There was a problem hiding this comment.
I think you may have changed them all except this one? ;-)
There was a problem hiding this comment.
Forgot to push that one.
| end) | ||
| UIManager:close(self.download_dialog) | ||
| UIManager:show(InfoMessage:new{ | ||
| text = _("Downloading may take several minutes…"), |
There was a problem hiding this comment.
Should we make this a local variable a little further up?
There was a problem hiding this comment.
I believe text is a member of the Button.
There was a problem hiding this comment.
I mean the string that's copied 10 times.
There was a problem hiding this comment.
Ah yes. Might take the opportunity to make it something nicer, "several minutes" seems a bit pessimistic for the type of files useful on an ebook reader.
Please wait while your file is downloading.
Download in progress.
?
There was a problem hiding this comment.
Sure, although at least for my ereader and file use it hardly seems pessimistic. (I tend to go for USB most of the time, and SSH otherwise.) My H2O doesn't come anywhere near the vicinity of the speed of my internet/wifi, regardless whether it's SD card speed/interface bound, wifi-chip bound or CPU bound. But my phone would indeed download a small 50 MB file in under 10 seconds.
I still think a little "don't panic" message might not be a bad idea though.
Downloading. This might take a moment.
There was a problem hiding this comment.
I've changed it.
The WiFi on the Clara is not amazing but too bad really. It didn't time exactly but a 5MB PDF took around 5s. I'm charging the old Kobo Mini to see if it much worse.
| local hint_folder = _("Start folder") | ||
| local text_folder = "" | ||
| local title | ||
| local text_button_right = _("Add") |
There was a problem hiding this comment.
I think it's a bit weird how all the button text has a "semantic" name and this one just _right. Maybe something like text_button_ok by analogy with ConfirmBox?
There was a problem hiding this comment.
Yep. Copied that from ftp.lua and forgot to change it. I didn't like the name either.
|
Thanks! |
Well, on my laptop that'd go at something like 150 Mbps ("250", it claims in connection speed info), limited by the slightly above 50 Mbps from my ISP if it's coming from the Internet. Even in the worst 50 Mbps scenario, that'd be 1 second for 5 MB. I don't know the precise H2O wifi speed, but something like 5-10 seconds probably sounds about right. But anyway, most books I look at are much bigger than 5 MB. :-) |
Addition of WebDav to the CloudStorage. The functionality is the same as with Dropbox and FTP, it is possible to browse the files on the server and download a copy.
Tested with: