Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump crengine: fix vertical-align and others #4307

Merged
merged 1 commit into from
Nov 4, 2018
Merged

bump crengine: fix vertical-align and others #4307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion base
Open in desktop
Submodule base updated 3 files
+36 −14 cre.cpp
+17 −2 thirdparty/cmake_modules/koreader_thirdparty_git.cmake
+1 −1 thirdparty/kpvcrlib/crengine
5 changes: 5 additions & 0 deletions frontend/ui/data/css_tweaks.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,11 @@ img {
}
]],
},
{
id = "image_valign_middle";
title = _("Middle align images with text"),
Copy link
Member

@Frenzie Frenzie Nov 17, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The natural way of saying this would be Vertically center images with text or Vertically center align images with text (line). I suspect they chose "middle" in CSS mainly to avoid confusion with horizontal centering. I only suspected what this might even mean because I know CSS.

Vertically middle align images with text would do the trick as well, although I think that middle verges toward CSS jargon if not plain ungrammaticality.

For support, here's the relevant dialog from Word:

2018-11-17 08_47_34-layout vertical alignment

css = [[img { vertical-align: middle; }]],
},
},
-- No current need for workarounds
-- {
Expand Down