New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] DPI: show concrete numbers and add more custom DPI presets #4389

Merged
merged 1 commit into from Dec 8, 2018

Conversation

Projects
None yet
4 participants
@Frenzie
Copy link
Member

Frenzie commented Dec 8, 2018

Follow-up of #4388.

Implements the suggestion by @turkeyphant from #2589 (comment).

Also adds a little explanatory message when holding on the Auto DPI option.

Before

screenshot_2018-12-08_21-17-31

After

screenshot_2018-12-08_21-15-42
screenshot_2018-12-08_21-15-49

[UX] DPI: show concrete numbers and add more custom DPI presets
Follow-up of #4388.

Implements the suggestion by @turkeyphant from <#2589 (comment)>.

Also adds a little explanatory message when holding on the Auto DPI option.

@Frenzie Frenzie added the UX label Dec 8, 2018

@poire-z

poire-z approved these changes Dec 8, 2018

@Frenzie Frenzie merged commit 0407b57 into koreader:master Dec 8, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@Frenzie Frenzie deleted the Frenzie:custom-dpi-deux branch Dec 8, 2018

@turkeyphant

This comment has been minimized.

Copy link

turkeyphant commented Dec 9, 2018

Thanks so much for the swift attention.

@AlanSP1

This comment has been minimized.

Copy link

AlanSP1 commented Dec 9, 2018

@Frenzie

This comment has been minimized.

Copy link
Member

Frenzie commented Dec 9, 2018

Thanks. I added it to the sidebar too. ;-)

@poire-z

This comment has been minimized.

Copy link
Contributor

poire-z commented Jan 15, 2019

2 small things I just noticed with Auto DPI:
The number aside the Auto DPI is not the value we will get when selecting it, but the current value (from the other previously selected menu item). And this %1 not filled (when hitting Auto DPI only).
image

@Frenzie

This comment has been minimized.

Copy link
Member

Frenzie commented Jan 15, 2019

I probably won't be able to take a look at it tomorrow, so hopefully I'll remember it for Thursday. ;-)

@poire-z

This comment has been minimized.

Copy link
Contributor

poire-z commented Jan 19, 2019

so hopefully I'll remember it for Thursday. ;-)

Looks like you didn't :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment