[UX] DPI: show concrete numbers and add more custom DPI presets #4389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up of koreader#4388. Implements the suggestion by @turkeyphant from <koreader#2589 (comment)>. Also adds a little explanatory message when holding on the Auto DPI option.
poire-z
approved these changes
Dec 8, 2018
|
Thanks so much for the swift attention. |
|
Added to wiki: https://github.com/koreader/koreader/wiki/DPI-control |
|
Thanks. I added it to the sidebar too. ;-) |
|
2 small things I just noticed with |
|
I probably won't be able to take a look at it tomorrow, so hopefully I'll remember it for Thursday. ;-) |
Looks like you didn't :) |
Frenzie
added a commit
to Frenzie/koreader
that referenced
this pull request
Feb 1, 2019
Simply don't mention any values when the device DPI isn't known. A more robust auto-DPI info function could be added to Screen but I'm not sure if it's worth the trouble. Fixes koreader#4389 (comment)
Frenzie
added a commit
that referenced
this pull request
Feb 1, 2019
Simply don't mention any values when the device DPI isn't known. A more robust auto-DPI info function could be added to Screen but I'm not sure if it's worth the trouble. Fixes #4389 (comment)
mwoz123
pushed a commit
to mwoz123/koreader
that referenced
this pull request
Mar 29, 2020
Simply don't mention any values when the device DPI isn't known. A more robust auto-DPI info function could be added to Screen but I'm not sure if it's worth the trouble. Fixes koreader#4389 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #4388.
Implements the suggestion by @turkeyphant from #2589 (comment).
Also adds a little explanatory message when holding on the Auto DPI option.
Before
After