Fixed Wallabag plugin's parsing of wrong API url. #4501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Wallabag plugin's callAPI() method was attempting to parse the user supplied URL for the Wallabag API. Unfortunately, the parse was silently failing since the variable apiurl did not contain a complete URL. The scheme of the parsed URL (always nil) was then used to select either http or https (default). The result being https was always selected, regardless of the user supplied setting. The parsed URL was switched to the variable server_url instead of apiurl but the behavior resulting in the default selection of https when parsing fails was left unchanged.
|
Thanks! |
mwoz123
pushed a commit
to mwoz123/koreader
that referenced
this pull request
Mar 29, 2020
The Wallabag plugin's callAPI() method was attempting to parse the user supplied URL for the Wallabag API. Unfortunately, the parse was silently failing since the variable apiurl did not contain a complete URL. The scheme of the parsed URL (always nil) was then used to select either http or https (default). The result being https was always selected, regardless of the user supplied setting. The parsed URL was switched to the variable server_url instead of apiurl but the behavior resulting in the default selection of https when parsing fails was left unchanged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Wallabag plugin's callAPI() method was attempting to parse the user supplied
URL for the Wallabag API. Unfortunately, the parse was silently failing since
the variable apiurl did not contain a complete URL. The scheme of the parsed
URL (always nil) was then used to select either http or https (default). The
result being https was always selected, regardless of the user supplied setting.
The parsed URL was switched to the variable server_url instead of apiurl but the
behavior resulting in the default selection of https when parsing fails was left
unchanged.