Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stricter WiFi callback #4616

Merged
merged 5 commits into from Feb 20, 2019

Conversation

Projects
None yet
2 participants
@NiLuJe
Copy link
Member

NiLuJe commented Feb 18, 2019

Double-checks that the connection was successful, and forcefully kills WiFi if it didn't, to avoid leaving stuff in an inconsistent state.

Should fix #2183

@NiLuJe

This comment has been minimized.

Copy link
Member Author

NiLuJe commented Feb 18, 2019

Possibly needs testing on Cervantes, as @pazos suggested.

Appears to behave on Kobo, but then I don't have connectivity/password issues, so the extent of my test was inverting the logic to kill wifi on a successful connection ;).

The Kindle case should be harmless (and beneficial there too, because ET call home).

@NiLuJe

This comment has been minimized.

Copy link
Member Author

NiLuJe commented Feb 19, 2019

Limit the whole thing to Kobo/Cervantes, the only two platforms where we load/unload kernel modules.

Because the connection check could be actively harmful on platforms where WiFi handling is always asynchronous, as there's a good chance the callback will run before WiFi is properly brought up.

@Frenzie Frenzie merged commit 869b8ae into koreader:master Feb 20, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@Frenzie Frenzie added bug Kobo labels Feb 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.