-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] Gesture manager: check multiswipe defaults #4623
Conversation
Pointed out by @poire-z Also add default previous location action for left, down.
We had some tricky discussion in the past about how to understand swipe west/left/to the left and stuff like that, so I'm still not sure how to reference the gesture. koreader/frontend/apps/reader/modules/readerlink.lua Lines 625 to 634 in 5495c5d
So, I guess that if you're adding an alternate gesture for people who would disable "Swipe to go back" to avoid conflict with swipe to turn page, your multiswipe gesture should have "east", instead of "west" in "multiswipe_west_south". |
Which imo is a odd and counter-intuitive (because right is forward). Sure, it depends on whether you think of it as dragging the page or as gesturing, but I find it a very confusing gesture when enabled. Also, the rewind gesture as popularly implemented in Opera over 15 years ago, now in Otter and Vivaldi, goes the same way. It feels very natural, with years of muscle memory. https://help.opera.com/en/presto/fast-browsing/#gestures Here's Vivaldi's excellent visualization. ;-) (As a compromise we could add it as a default for both… or just work on making those other gestures configurable sooner rather than later.) |
I get what you say, and you might have been gesturing with a mouse too much :) (I really never did...) |
Sorry, I mostly just got confused. I'd swear there was at least one incredibly counter-intuitive one among those settings and for some reason I thought it was that one. I guess my only real issue with them is that they override normal left/right navigation. What about left, right instead? |
For getting back from link? Why not, feels like "shake" to go back :) Personally, (*) I may just set east+south to show TOC and west+south to show Bookmarks, similar to the existing 2 fingers swipes that show them in these directions, just to be able to do them one handed (for 2 fingers, you need the other hand to hold the device). And I'll probably set all the other ones to "nothing" - just because I sometimes break a swipe with an angle to just cancel the one I was making if I changed my mind). I'm a bit uncertain about if we should set defaults for multi gestures. We don't have much actions, they are all mostly one or two tap away. It comes down to personal usage. Having multi gestures set to something by default may surprise some people, who will have to go disabling them. But it's also one way to advertise that new feature :) (*: when you'll have solved that distance/direction bug :) |
I guess I am getting out of date, to me gestures are not the first option but there to provide more options when there would otherwise be a conflict with the normal tap on the screen. The new proposed gesture management and added gesture capability sounds great, as a means to implement new or alternative controls. The original tap controls should remain defaults, for consistency. Just an opinion, of course. |
@KenMaltby |
Well, don't forget that the first time you accidentally make one there's the introductory message. I think having a defined set of defaults makes it much easier to play around with on the first encounter.
This could be presented slightly more elegantly once there actually is a set of defaults. By doing so, only people who don't like the defaults have to go through the additional effort of changing them.
Funny, I do my "crossing out" a bit wilder, which works out just fine. :-)
|
Accidentally broken in koreader#4623 Also see koreader#4640 (comment)
Accidentally broken in #4623 Also see #4640 (comment)
Revising my judgment about not needing to set defaults :) I think this multiswipe thingy is wonderful, and makes many things easier. And no other reader must have it, so we might as well set defaults so they are the de-facto standard for the future of e-readers ! :) So, sharing what I have set and found useful, and the why (for me) of the gestures chosen - so that we can decide quickly which to set so I don't become too accustomed to mine if we decide for others :)
These all first go up towards the top menu, so indicating some stuff related to other books list or switch. (In any case, please add No real opinion (yet) about: |
I have set my multiswipe as described above. But after a few hours of using them, and still not having the reflexes, so having to think about them... I feel it is more natural the other way around :| :
So, it would feel right for all the others to be inverted too,.. Well, not easy to decide for defaults if I'm not even sure about my own preferences :) |
In terms of the Gesture Management, the listing of functions/actions that are available for mapping to a gesture would be interesting, at least the "roll out" list. Most would be like "Full Screen Refresh" and present no problems, even if accidently activated. Something like "Factory Reset" would be a different story. Some gestures might best be toggles or have the reverse gestures be a "cancel" of the action. |
↦ ↤ should be jump to latest bookmark as the companion to back to previous location. (Still to be added to the arsenal.) I think swipe to follow nearest link could also work as a multiswipe. Fwiw, the traditional Opera/Otter/Vivaldi link gestures are |
Pointed out by @poire-z Also add default previous location action for left, right.
Accidentally broken in koreader#4623 Also see koreader#4640 (comment)
Pointed out by @poire-z
Also add default previous location action for left, down.