Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
[UX] Add Device:openLink() stub for Linux SDL #4822
It's minimal for now and non intrusive to other platforms, so probably fine.
But I guess one could still like to see the url in a confirmBox and confirm he really wants to launch a fat web browser to go there.
On Android, I guess it should launch an intent that would be catch by any app able to handle http:// links.
It becomes harder on new android versions, but yeah. We need to take a string with url and create a new Uri with http scheme and then start the new activity via intent (we should catch the ActivityNotFound error that triggers if no activity is registered to view that kind of scheme and, optionally, notify the user that no external browser is available via android.notification).
I don't really know what intrusive could even mean here? :-)
I'd say that's a matter for the URL handler, not for KOReader. If the URL handler launches a "fat web browser" that's the user's choice outside of KOReader. (Same for Android.) But sure, some kind of additional setting could be added in the future.