New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UX] Add Device:openLink() stub for Linux SDL #4822
Conversation
It's minimal for now and non intrusive to other platforms, so probably fine. But I guess one could still like to see the url in a confirmBox and confirm he really wants to launch a fat web browser to go there. On Android, I guess it should launch an intent that would be catch by any app able to handle http:// links. |
It becomes harder on new android versions, but yeah. We need to take a string with url and create a new Uri with http scheme and then start the new activity via intent (we should catch the ActivityNotFound error that triggers if no activity is registered to view that kind of scheme and, optionally, notify the user that no external browser is available via android.notification). |
I don't really know what intrusive could even mean here? :-)
I'd say that's a matter for the URL handler, not for KOReader. If the URL handler launches a "fat web browser" that's the user's choice outside of KOReader. (Same for Android.) But sure, some kind of additional setting could be added in the future. @pazos |
Fixes koreader#4821 Same as koreader#4822 Thanks to @pazos who implemented the Android backend, see koreader/android-luajit-launcher#133
Fixes #4821 Same as #4822 Thanks to @pazos who implemented the Android backend, see koreader/android-luajit-launcher#133
Fixes koreader#4821 Same as koreader#4822 Thanks to @pazos who implemented the Android backend, see koreader/android-luajit-launcher#133
References #4821.