Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open urls in external browser #133

Merged
merged 1 commit into from
Mar 20, 2019
Merged

open urls in external browser #133

merged 1 commit into from
Mar 20, 2019

Conversation

pazos
Copy link
Member

@pazos pazos commented Mar 20, 2019

Related to koreader/koreader#4821 and koreader/koreader#4822

Tested on a device opening "https://koreader.rocks".

Copy link
Member

@Frenzie Frenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was quick. :-)

@Frenzie Frenzie merged commit 98786ee into koreader:master Mar 20, 2019
@pazos
Copy link
Member Author

pazos commented Mar 20, 2019

@Frenzie: will you take care of the frontend code? It should be almost the same, but replacing

return os.execute("xdg-open '"..link.."'") == 0 with
return android.openLink(link) == 0

@pazos pazos deleted the open_link branch March 20, 2019 16:05
@Frenzie
Copy link
Member

Frenzie commented Mar 20, 2019

Alright, I'll do it quickly before I leave.

Frenzie added a commit to Frenzie/koreader that referenced this pull request Mar 20, 2019
Frenzie added a commit to koreader/koreader that referenced this pull request Mar 20, 2019
mwoz123 pushed a commit to mwoz123/koreader that referenced this pull request Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants