[sdl] Add support arrow key for next/prev page #5149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frenzie
reviewed
Jul 28, 2019
Co-Authored-By: Frans de Jonge <fransdejonge@gmail.com>
NiLuJe
reviewed
Jul 28, 2019
| @@ -43,13 +43,22 @@ function ReaderPaging:init() | |||
| self.key_events = {} | |||
| if Device:hasKeys() then | |||
| self.key_events.GotoNextPage = { | |||
| {Input.group.PgFwd}, doc = "go to next page", | |||
| { {"RPgFwd", "LPgFwd", "Right" } }, doc = "go to next page", | |||
There was a problem hiding this comment.
Was there an issue with simply adding Left/Right to the PgBack/PgFwd input groups?
There was a problem hiding this comment.
input.group.PgFwd/PgBack is also used in another places eg. scrolltextwidget, keyvaluepage etc.
There was a problem hiding this comment.
Okay, that's what I thought, thanks for the confirmation ;).
mwoz123
pushed a commit
to mwoz123/koreader
that referenced
this pull request
Mar 29, 2020
Close: koreader#4997 This PR add support arrow key and mouse scroll wheel for next/previous page. - Document in page mode: PageDown, Arrow down, Arrow right - go to next page PageUp, Arrow up, arrow left - go to prev page Mouse scroll wheel down - go to next page Mouse scroll wheel up - go to prev page - Document in scroll mode: PageDown, Arrow right - go to next page PageUp, Arrow, arrow left - go to prev page Arrow down - scroll document down Arrow up - scroll document up Mouse scroll wheel down - scroll document down Mouse scroll wheel up - scroll document up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close: #4997
This PR add support arrow key and mouse scroll wheel for next/previous page.
PageDown, Arrow down, Arrow right - go to next page
PageUp, Arrow up, arrow left - go to prev page
Mouse scroll wheel down - go to next page
Mouse scroll wheel up - go to prev page
PageDown, Arrow right - go to next page
PageUp, Arrow, arrow left - go to prev page
Arrow down - scroll document down
Arrow up - scroll document up
Mouse scroll wheel down - scroll document down
Mouse scroll wheel up - scroll document up