Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sdl] Add support arrow key for next/prev page #5149

Merged
merged 3 commits into from Jul 28, 2019

Conversation

@robert00s
Copy link
Contributor

commented Jul 28, 2019

Close: #4997
This PR add support arrow key and mouse scroll wheel for next/previous page.

  • Document in page mode:

PageDown, Arrow down, Arrow right - go to next page
PageUp, Arrow up, arrow left - go to prev page
Mouse scroll wheel down - go to next page
Mouse scroll wheel up - go to prev page

  • Document in scroll mode:

PageDown, Arrow right - go to next page
PageUp, Arrow, arrow left - go to prev page
Arrow down - scroll document down
Arrow up - scroll document up
Mouse scroll wheel down - scroll document down
Mouse scroll wheel up - scroll document up

@Frenzie Frenzie added this to the 2019.08 milestone Jul 28, 2019

Update frontend/apps/reader/modules/readerpaging.lua
Co-Authored-By: Frans de Jonge <fransdejonge@gmail.com>

@Frenzie Frenzie merged commit 803a143 into koreader:master Jul 28, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
@@ -43,13 +43,22 @@ function ReaderPaging:init()
self.key_events = {}
if Device:hasKeys() then
self.key_events.GotoNextPage = {
{Input.group.PgFwd}, doc = "go to next page",
{ {"RPgFwd", "LPgFwd", "Right" } }, doc = "go to next page",

This comment has been minimized.

Copy link
@NiLuJe

NiLuJe Jul 28, 2019

Member

Was there an issue with simply adding Left/Right to the PgBack/PgFwd input groups?

This comment has been minimized.

Copy link
@robert00s

robert00s Jul 28, 2019

Author Contributor

input.group.PgFwd/PgBack is also used in another places eg. scrolltextwidget, keyvaluepage etc.

This comment has been minimized.

Copy link
@NiLuJe

NiLuJe Jul 28, 2019

Member

Okay, that's what I thought, thanks for the confirmation ;).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.