Never full refresh #5227
Merged
Never full refresh #5227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I use 22 on mine and I'd probably be happy with 99, but literally never doesn't strike me as desirable. I definitely prefer the occasional possibly redundant flash over having to manually trigger screen refreshes. But whatever, I guess that's up to the user. ¯_(ツ)_/¯ Edit: oh, I see. Full refresh is still triggered by dictionary lookup and such as per the linked issue. |
poire-z
reviewed
Aug 19, 2019
| local function custom_2() return G_reader_settings:readSetting("refresh_rate_2") or 22 end | ||
|
|
||
| local function custom_3() return G_reader_settings:readSetting("refresh_rate_3") or 99 end | ||
| local function custom(refresh_rate_type) |
There was a problem hiding this comment.
nitpick, but for read/understandability, refresh_rate_type is a bit misleading, refresh_rate_num or custom_refresh_rate_setting_name is probably clearer.
| return { | ||
| text = _("Full refresh rate"), | ||
| separator = true, | ||
| sub_item_table = { | ||
| { | ||
| text = _("Never refresh"), |
There was a problem hiding this comment.
Or just Never or Manually ? @Frenzie ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Never refreshinSettings -> Screen -> E-ink settings -> Full refresh rate.