Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Never full refresh #5227

Merged
merged 2 commits into from Aug 20, 2019

Conversation

@robert00s
Copy link
Contributor

commented Aug 19, 2019

  • add Never refresh in Settings -> Screen -> E-ink settings -> Full refresh rate.
  • spinnerWidget insteed of inputWidget after long press Cutom x
  • After changing the value, the menu label is now updated see: #5190 (comment)

obraz

obraz

@Frenzie Frenzie added this to the 2019.09 milestone Aug 19, 2019

@Frenzie

This comment has been minimized.

Copy link
Member

commented Aug 19, 2019

I use 22 on mine and I'd probably be happy with 99, but literally never doesn't strike me as desirable. I definitely prefer the occasional possibly redundant flash over having to manually trigger screen refreshes. But whatever, I guess that's up to the user. ¯_(ツ)_/¯

Edit: oh, I see. Full refresh is still triggered by dictionary lookup and such as per the linked issue.

local function custom_2() return G_reader_settings:readSetting("refresh_rate_2") or 22 end

local function custom_3() return G_reader_settings:readSetting("refresh_rate_3") or 99 end
local function custom(refresh_rate_type)

This comment has been minimized.

Copy link
@poire-z

poire-z Aug 19, 2019

Contributor

nitpick, but for read/understandability, refresh_rate_type is a bit misleading, refresh_rate_num or custom_refresh_rate_setting_name is probably clearer.

This comment has been minimized.

Copy link
@robert00s

robert00s Aug 20, 2019

Author Contributor

Done :)

return {
text = _("Full refresh rate"),
separator = true,
sub_item_table = {
{
text = _("Never refresh"),

This comment has been minimized.

Copy link
@poire-z

poire-z Aug 19, 2019

Contributor

Or just Never or Manually ? @Frenzie ?

This comment has been minimized.

Copy link
@Frenzie

Frenzie Aug 19, 2019

Member

Manual and UI?

This comment has been minimized.

Copy link
@robert00s

robert00s Aug 20, 2019

Author Contributor

I use Never.

@Frenzie Frenzie merged commit d9018fa into koreader:master Aug 20, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.