Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix frozen confirmbox when keyboard shown #5452

Merged
merged 2 commits into from
Oct 4, 2019
Merged

Fix frozen confirmbox when keyboard shown #5452

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b5ee87
sendEvent() checks other modal widgets(if they exists) if top_widget …
mustafa-001 Oct 2, 2019
5e2190b
ckecks if widget is modal only when is_always_active fails
mustafa-001 Oct 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion frontend/ui/uimanager.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -694,10 +694,12 @@ function UIManager:sendEvent(event)
if active_widget:handleEvent(event) then return end
end
end
if widget.widget.is_always_active then
if widget.widget.is_always_active or widget.widget.modal then
-- active widgets will handle this event
-- Note: is_always_active widgets currently are widgets that want to show a keyboard
-- and readerconfig
-- By default modal widgets are always on top but if there is more than one modal
-- widget, only last one will be top_widget. e.g. keyboard and confirmbox.
checked_widgets[widget] = true
if widget.widget:handleEvent(event) then return end
end
Expand Down